swirc: update to 3.3.1. #32933
Merged
swirc: update to 3.3.1. #32933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericonr
reviewed
Sep 13, 2021
srcpkgs/swirc/template
Outdated
Comment on lines
6
to
8
| configure_args="--without-libintl" | ||
| make_install_args="PREFIX=/usr" | ||
| make_install_target="install-no-lc-msgs" |
There was a problem hiding this comment.
Why did you prefer to remove libintl?
There was a problem hiding this comment.
Is it okey to install stuff under /usr/local? Else main.cpp needs modification in the bindtextdomain() call. Maybe I can write a patch?
There was a problem hiding this comment.
For context: https://github.com/uhlin/swirc/blob/332223632e8667a1e649a491f20b9b0627928797/src/main.cpp#L507
Please try to write a patch, yes. The patch in our side can simply hardcode the path we install to, but if you'd like to upstream a change so it uses the path passed to Make, that'd be ideal. Or open an issue and request it :)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swirc 3.3.1 out