Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: zellij-0.20.1 #32990

Closed
wants to merge 1 commit into from

Conversation

kartikynwa
Copy link
Contributor

@kartikynwa kartikynwa commented Sep 17, 2021

General

Have the results of the proposed changes been tested?

  • I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
    • I have been using the zellij for a couple of days and have only written the template for it today. Let me know if you have any questions.
  • I generally don't use the affected packages but briefly tested this PR

Does it build and run successfully?

(Please choose at least one native build and, if supported, at least one cross build. More are better.)

  • I built this PR locally for my native architecture, (x86_64-glibc)
  • I built this PR locally for these architectures (if supported. mark crossbuilds):
    • aarch64-musl
    • armv7l
    • armv6l-musl

@kartikynwa kartikynwa force-pushed the new-package-zellij branch 3 times, most recently from ead0112 to 545a39f Compare September 17, 2021 12:45
srcpkgs/zellij/template Outdated Show resolved Hide resolved
@kartikynwa kartikynwa force-pushed the new-package-zellij branch 2 times, most recently from 8302912 to 17c4f82 Compare September 17, 2021 13:56
@kartikynwa
Copy link
Contributor Author

Seems like builds are all passing now. But one failed because cargo failed to fetch the dependency. I'll try force pushing a commit later to restart CI.

@kartikynwa kartikynwa force-pushed the new-package-zellij branch 2 times, most recently from 0437b33 to 7cab688 Compare September 18, 2021 05:48
@paper42 paper42 added the new-package This PR adds a new package label Sep 18, 2021
@Johnnynator
Copy link
Member

Please at a comment to template why the arch is restricted (and maybe a link to the upstream documentation pointing it out)

@kartikynwa
Copy link
Contributor Author

kartikynwa commented Sep 19, 2021

@Johnnynator Have added comments explaining the arch choice: https://github.com/void-linux/void-packages/pull/32990/files#diff-875aae87a3c8acfe875a587b9952e420b23c2f2dba886b06875fa2dfb8b29386R5-R6

edit: Please feel free to suggest any other changes

srcpkgs/zellij/template Outdated Show resolved Hide resolved
@kartikynwa kartikynwa changed the title New package: zellij-0.17.0 New package: zellij-0.18.1 Oct 1, 2021
@kartikynwa kartikynwa changed the title New package: zellij-0.18.1 New package: zellij-0.19.0 Oct 22, 2021
@kartikynwa kartikynwa changed the title New package: zellij-0.19.0 New package: zellij-0.20.1 Nov 12, 2021
@kartikynwa
Copy link
Contributor Author

Seems like newer rust is needed for the new version. Will close the PR for the meanwhile.

@kartikynwa kartikynwa closed this Nov 12, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new-package This PR adds a new package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants