Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Package: runit-backlight-20200420 #33096

Closed
wants to merge 1 commit into from

Conversation

StellarOrbit
Copy link

@StellarOrbit StellarOrbit commented Sep 25, 2021

General

Have the results of the proposed changes been tested?

  • I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
  • I generally don't use the affected packages but briefly tested this PR

@abenson
Copy link
Contributor

abenson commented Sep 25, 2021

Drop the commits related to NetworkManager-fortisslvpn

srcpkgs/backlight/template Outdated Show resolved Hide resolved
srcpkgs/backlight/template Outdated Show resolved Hide resolved
srcpkgs/backlight/template Outdated Show resolved Hide resolved
@StellarOrbit
Copy link
Author

Drop the commits related to NetworkManager-fortisslvpn

Not sure why those were added here since I changed branches and did a PR

srcpkgs/backlight/template Outdated Show resolved Hide resolved
srcpkgs/backlight/template Outdated Show resolved Hide resolved
srcpkgs/backlight/template Outdated Show resolved Hide resolved
@StellarOrbit StellarOrbit force-pushed the backlight branch 3 times, most recently from b208d8b to f040d26 Compare October 1, 2021 02:30
@StellarOrbit StellarOrbit changed the title New Package: backlight-20200420 New Package: runit-backlight-20200420 Oct 1, 2021
@paper42 paper42 added the new-package This PR adds a new package label Oct 1, 2021
@Duncaen
Copy link
Member

Duncaen commented Oct 1, 2021

What is the point of making this a fake service?

@ericonr
Copy link
Member

ericonr commented Oct 1, 2021

I think the consensus was to not package exec pause services any more? The first part here can happen in core-services instead, shut down is the complicated one.

@StellarOrbit
Copy link
Author

What is the point of making this a fake service?

I would say the purpose of this service is so that when you reboot, your screen brightness can be maintained across the reboots, rather than just resetting itself back to defaults.

@StellarOrbit
Copy link
Author

I think the consensus was to not package exec pause services any more? The first part here can happen in core-services instead, shut down is the complicated one.

I see. So what would you recommend for making this more suitable for void linux? Having screen brightness that doesn't reset across reboots was a big sticking point for me with other runit based distros.

@ericonr
Copy link
Member

ericonr commented Nov 14, 2021

I'm not sure. Maybe provide a small script around a tool like brightnessctl that can be added to rc.local?

@github-actions
Copy link

github-actions bot commented Jun 5, 2022

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label Jun 5, 2022
@github-actions github-actions bot closed this Jun 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-package This PR adds a new package Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants