Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3-networkx: update to 2.6.3. #33212

Merged
merged 1 commit into from Oct 2, 2021
Merged

Conversation

pbui
Copy link
Contributor

@pbui pbui commented Oct 1, 2021

General

Have the results of the proposed changes been tested?

  • I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
  • I generally don't use the affected packages but briefly tested this PR

Copy link
Member

@paper42 paper42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2.6 removes python3-decorator dependency

There are a few dependencies listed in requirements/default.txt, the library can be imported without them, do you know if it's usable without them?

@pbui
Copy link
Contributor Author

pbui commented Oct 1, 2021

@paper42 Thanks for taking a look. I have removed the python3-decorator dependency.

The basics of networkx work without the other packages... meaning you can create a graph, add nodes, add edges, and run various algorithms on the structures. You will need the other packages to visualize those structures however and perhaps do some processing.

I would be fine with adding them as actual dependencies as that is what Arch Linux does:

https://archlinux.org/packages/community/any/python-networkx/

And it is what the upstream authors list as requirements.

Let me know how you think we should proceed.

srcpkgs/python3-networkx/template Show resolved Hide resolved
srcpkgs/python3-networkx/template Outdated Show resolved Hide resolved
@paper42
Copy link
Member

paper42 commented Oct 1, 2021

The basics of networkx work without the other packages... meaning you can create a graph, add nodes, add edges, and run various algorithms on the structures. You will need the other packages to visualize those structures however and perhaps do some processing.

I would be fine with adding them as actual dependencies as that is what Arch Linux does

I think we should leave it like this, thank you for looking into it.

Drop python3-decorator and unzip as dependencies.
@paper42 paper42 merged commit c76b698 into void-linux:master Oct 2, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants