Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uthash: update to 2.3.0. #33265

Closed
wants to merge 1 commit into from
Closed

Conversation

bertronika
Copy link
Contributor

General

Have the results of the proposed changes been tested?

  • I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
  • I generally don't use the affected packages but briefly tested this PR

Does it build and run successfully?

(Please choose at least one native build and, if supported, at least one cross build. More are better.)

  • I built this PR locally for my native architecture, (x86_64)
  • I built this PR locally for these architectures (if supported. mark crossbuilds):
    • aarch64-musl
    • armv7l
    • armv6l-musl

I haven't done any crossbuilds since this is a header-only library. Project's ChangeLog.txt doesn't mention any changes regarding system architectures, so I believe we should be fine.

The 2.3.0 version is used in one of programs I'm developing, and no errors regarding the library are generated.

@Chocimier
Copy link
Member

Project's ChangeLog.txt mentions removal of few functions. Packages using this one should be checked if they still build.
Please fix xlint, add link to plaintext changelog.

Upstream changelog has been added and short description now passes
xlint.
@bertronika
Copy link
Contributor Author

I've amended the commit - added upstream changelog, fixed short description.

Regarding uthash deprecating functions: following seems to have been removed since 2.1.0:

  • HASH_FCN
  • uthash_memcmp
  • HASH_MUR
  • oom separated to utarray_oom and utstring_oom

I've checked upstream repos for the following packages, gathered with grep -rli utash in void-packages/srcpkgs:

  • alttab
  • picom
  • xcb-imdkit
  • burp2-server
  • rmilter
  • logtop
  • mle
  • mhddfs
  • mosquitto

There were also a couple of patches:

  • wordgrinder/patches/fix-xft-include.patch
  • rmilter/patches/de-vendor.patch

As far as I can tell, none of the packages and patches are using the deprecated functions. Only occurrences of them were in uthash.h and other ut*.h files, included upstream, meaning those packages don't even depend on Void's version.

@Piraty
Copy link
Member

Piraty commented Oct 25, 2021

dependant packages build fine:

for p in $(grep -rl uthash srcpkgs | cut -d/ -f2) ; do ./xbps-src pkg $p ; done

@Piraty Piraty closed this in 67b736a Oct 25, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants