New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New package: soju-0.3.0 #33302
New package: soju-0.3.0 #33302
Conversation
|
Thanks, my bad I forgot to run |
Thanks for the review, I made the recommended changes. Uses the |
This should use a separate user, there is no reason to run an irc bouncer as root.
and I also switched the log and database directories, not sure if this would make sense:
And then chaning the default configuration to use those instead of |
I completely agree with this statement. My only gripe was that the database is only created when running
And users would have to make sure it is ran as
Yes, makes a lot of sense. On it. |
Did all the recommended changes. Defining a Thank you all, sorry for the tedious process, it's my first template. Slowly getting used to the void process. |
Some packages have a void specific readme, this would be a good case for that. This is done by adding a |
Added a |
Do you mind updating this to 0.3.0, this has been sitting a while and I don't see anything else blocking a merge. |
9386ca0
to
e2b27e4
Compare
Done! |
General
Have the results of the proposed changes been tested?
Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)