New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gitea: update to 1.15.3 #33361
gitea: update to 1.15.3 #33361
Conversation
-;REDIRECT_OTHER_PORT = false | ||
-;PORT_TO_REDIRECT = 80 | ||
+REDIRECT_OTHER_PORT = false | ||
+PORT_TO_REDIRECT = 80 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why change these? Those are the default values already.
From a34c208c262a5c66b560d9cb2e4652344a12b485 Mon Sep 17 00:00:00 2001 | ||
From: Twilighttony <starrbeartony14@zoho.com> | ||
Date: Wed, 6 Oct 2021 01:42:09 -0400 | ||
Subject: [PATCH] changes | ||
|
||
--- | ||
custom/conf/app.example.ini | 146 +++++++++++++----------------------- | ||
1 file changed, 51 insertions(+), 95 deletions(-) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't include this part of the patch (you can simply remove it and it should work).
-;SSH_LISTEN_PORT = %(SSH_PORT)s | ||
+SSH_LISTEN_PORT = %(SSH_PORT)s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why set the default?
-;SSH_ROOT_PATH = | ||
+SSH_ROOT_PATH = /var/lib/gitea |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We were setting it to empty previously, why change?
;; Gitea will create a authorized_keys file by default when it is not using the internal ssh server | ||
;; If you intend to use the AuthorizedKeysCommand functionality then you should turn this off. | ||
-;SSH_CREATE_AUTHORIZED_KEYS_FILE = true | ||
+SSH_CREATE_AUTHORIZED_KEYS_FILE = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why touch the default?
-;SCHEDULE = @midnight | ||
+;SCHEDULE = @every 24h | ||
;; Archives created more than OLDER_THAN ago are subject to deletion | ||
;OLDER_THAN = 24h | ||
|
||
@@ -1705,7 +1697,7 @@ PATH = | ||
;[cron.repo_health_check] | ||
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; | ||
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; | ||
-;SCHEDULE = @midnight | ||
+;SCHEDULE = @every 24h |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why?
-;SCHEDULE = @midnight | ||
+;SCHEDULE = @every 24h | ||
|
||
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; | ||
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; | ||
@@ -1744,7 +1736,7 @@ PATH = | ||
;; Notice if not success | ||
;NO_SUCCESS_NOTICE = false | ||
;; Interval as a duration between each synchronization. (default every 24h) | ||
-;SCHEDULE = @midnight | ||
+;SCHEDULE = @every 24h | ||
|
||
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; | ||
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; | ||
@@ -1759,7 +1751,7 @@ PATH = | ||
;; Notice if not success | ||
;NO_SUCCESS_NOTICE = false | ||
;; Interval as a duration between each synchronization (default every 24h) | ||
-;SCHEDULE = @midnight | ||
+;SCHEDULE = @every 24h |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why?
-;SCHEDULE = @midnight | ||
+;SCHEDULE = @every 24h | ||
;; deleted branches than OLDER_THAN ago are subject to deletion | ||
;OLDER_THAN = 24h | ||
|
||
@@ -1793,7 +1785,7 @@ PATH = | ||
;; Whether to always run at start up time (if ENABLED) | ||
;RUN_AT_START = false | ||
;; Time interval for job to run | ||
-;SCHEDULE = @midnight | ||
+;SCHEDULE = @every 24h |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why?
-;NO_SUCCESS_NOTICE = false | ||
+;NO_SUCCESS_NOTICE = f;alse | ||
;SCHEDULE = @every 72h | ||
|
||
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; | ||
@@ -1907,7 +1899,7 @@ PATH = | ||
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; | ||
;ENABLED = false | ||
;RUN_AT_START = false | ||
-;NO_SUCCESS_NOTICE = false | ||
+;NO_SUCCESS_NOTICE = f;alse |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You broke these
-;LANGS = en-US,zh-CN,zh-HK,zh-TW,de-DE,fr-FR,nl-NL,lv-LV,ru-RU,uk-UA,ja-JP,es-ES,pt-BR,pt-PT,pl-PL,bg-BG,it-IT,fi-FI,tr-TR,cs-CZ,sr-SP,sv-SE,ko-KR,el-GR,fa-IR,hu-HU,id-ID,ml-IN | ||
-;NAMES = English,简体中文,繁體中文(香港),繁體中文(台灣),Deutsch,français,Nederlands,latviešu,русский,Українська,日本語,español,português do Brasil,Português de Portugal,polski,български,italiano,suomi,Türkçe,čeština,српски,svenska,한국어,ελληνικά,فارسی,magyar nyelv,bahasa Indonesia,മലയാളം | ||
+;LANGS = en-US,zh-CN,zh-HK,zh-TW,de-DE,fr-FR,nl-NL,lv-LV,ru-RU,uk-UA,ja-JP,es-ES,pt-BR,pt-PT,pl-PL,bg-BG,it-IT,fi-FI,tr-TR,cs-CZ,sr-SP,sv-SE,ko-KR | ||
+;NAMES = English,简体中文,繁體中文(香港),繁體中文(台灣),Deutsch,français,Nederlands,latviešu,русский,Українська,日本語,español,português do Brasil,Português de Portugal,polski,български,italiano,suomi,Türkçe,čeština,српски,svenska,한국어 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just generally made changes to the file that was already specified in the old .patch that already existed in the template
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current patch doesn't remove languages from this list.
Closed in 19d986a |
General
Have the results of the proposed changes been tested?