Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitea: update to 1.15.3 #33361

Closed
wants to merge 1 commit into from
Closed

Conversation

StellarOrbit
Copy link

@StellarOrbit StellarOrbit commented Oct 6, 2021

General

Have the results of the proposed changes been tested?

  • I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
  • I generally don't use the affected packages but briefly tested this PR

Comment on lines +27 to +30
-;REDIRECT_OTHER_PORT = false
-;PORT_TO_REDIRECT = 80
+REDIRECT_OTHER_PORT = false
+PORT_TO_REDIRECT = 80
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why change these? Those are the default values already.

Comment on lines +1 to +9
From a34c208c262a5c66b560d9cb2e4652344a12b485 Mon Sep 17 00:00:00 2001
From: Twilighttony <starrbeartony14@zoho.com>
Date: Wed, 6 Oct 2021 01:42:09 -0400
Subject: [PATCH] changes

---
custom/conf/app.example.ini | 146 +++++++++++++-----------------------
1 file changed, 51 insertions(+), 95 deletions(-)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't include this part of the patch (you can simply remove it and it should work).

Comment on lines +47 to +48
-;SSH_LISTEN_PORT = %(SSH_PORT)s
+SSH_LISTEN_PORT = %(SSH_PORT)s
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why set the default?

Comment on lines +51 to 52
-;SSH_ROOT_PATH =
+SSH_ROOT_PATH = /var/lib/gitea
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We were setting it to empty previously, why change?

Comment on lines +54 to +57
;; Gitea will create a authorized_keys file by default when it is not using the internal ssh server
;; If you intend to use the AuthorizedKeysCommand functionality then you should turn this off.
-;SSH_CREATE_AUTHORIZED_KEYS_FILE = true
+SSH_CREATE_AUTHORIZED_KEYS_FILE = true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why touch the default?

Comment on lines +237 to +247
-;SCHEDULE = @midnight
+;SCHEDULE = @every 24h
;; Archives created more than OLDER_THAN ago are subject to deletion
;OLDER_THAN = 24h

@@ -1705,7 +1697,7 @@ PATH =
;[cron.repo_health_check]
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
-;SCHEDULE = @midnight
+;SCHEDULE = @every 24h
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

Comment on lines +255 to +274
-;SCHEDULE = @midnight
+;SCHEDULE = @every 24h

;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
@@ -1744,7 +1736,7 @@ PATH =
;; Notice if not success
;NO_SUCCESS_NOTICE = false
;; Interval as a duration between each synchronization. (default every 24h)
-;SCHEDULE = @midnight
+;SCHEDULE = @every 24h

;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
@@ -1759,7 +1751,7 @@ PATH =
;; Notice if not success
;NO_SUCCESS_NOTICE = false
;; Interval as a duration between each synchronization (default every 24h)
-;SCHEDULE = @midnight
+;SCHEDULE = @every 24h
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

Comment on lines +282 to +292
-;SCHEDULE = @midnight
+;SCHEDULE = @every 24h
;; deleted branches than OLDER_THAN ago are subject to deletion
;OLDER_THAN = 24h

@@ -1793,7 +1785,7 @@ PATH =
;; Whether to always run at start up time (if ENABLED)
;RUN_AT_START = false
;; Time interval for job to run
-;SCHEDULE = @midnight
+;SCHEDULE = @every 24h
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

Comment on lines +300 to +310
-;NO_SUCCESS_NOTICE = false
+;NO_SUCCESS_NOTICE = f;alse
;SCHEDULE = @every 72h

;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
@@ -1907,7 +1899,7 @@ PATH =
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
;ENABLED = false
;RUN_AT_START = false
-;NO_SUCCESS_NOTICE = false
+;NO_SUCCESS_NOTICE = f;alse
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You broke these

Comment on lines +319 to 323
-;LANGS = en-US,zh-CN,zh-HK,zh-TW,de-DE,fr-FR,nl-NL,lv-LV,ru-RU,uk-UA,ja-JP,es-ES,pt-BR,pt-PT,pl-PL,bg-BG,it-IT,fi-FI,tr-TR,cs-CZ,sr-SP,sv-SE,ko-KR,el-GR,fa-IR,hu-HU,id-ID,ml-IN
-;NAMES = English,简体中文,繁體中文(香港),繁體中文(台灣),Deutsch,français,Nederlands,latviešu,русский,Українська,日本語,español,português do Brasil,Português de Portugal,polski,български,italiano,suomi,Türkçe,čeština,српски,svenska,한국어,ελληνικά,فارسی,magyar nyelv,bahasa Indonesia,മലയാളം
+;LANGS = en-US,zh-CN,zh-HK,zh-TW,de-DE,fr-FR,nl-NL,lv-LV,ru-RU,uk-UA,ja-JP,es-ES,pt-BR,pt-PT,pl-PL,bg-BG,it-IT,fi-FI,tr-TR,cs-CZ,sr-SP,sv-SE,ko-KR
+;NAMES = English,简体中文,繁體中文(香港),繁體中文(台灣),Deutsch,français,Nederlands,latviešu,русский,Українська,日本語,español,português do Brasil,Português de Portugal,polski,български,italiano,suomi,Türkçe,čeština,српски,svenska,한국어

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just generally made changes to the file that was already specified in the old .patch that already existed in the template

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current patch doesn't remove languages from this list.

@ericonr
Copy link
Member

ericonr commented Nov 14, 2021

Closed in 19d986a

@ericonr ericonr closed this Nov 14, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants