Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: rockpro64-base and rockpro64-uboot #33494

Closed
wants to merge 8 commits into from
Closed

New package: rockpro64-base and rockpro64-uboot #33494

wants to merge 8 commits into from

Conversation

tiemenwerkman
Copy link

General

Have the results of the proposed changes been tested?

  • I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
  • I generally don't use the affected packages but briefly tested this PR

Does it build and run successfully?

(Please choose at least one native build and, if supported, at least one cross build. More are better.)

  • I built this PR locally for my native architecture, (ARCH-LIBC)
  • I built this PR locally for these architectures (if supported. mark crossbuilds):
    • aarch64-musl
    • armv7l
    • armv6l-musl

I'm not clear on what the build section above means. Here's what I did: I have built these packages on my desktop pc which is x86_64. When building the packages I specified "-a aarch64" to "./xbps-src" to build the packages for arm64. I believe that makes it a crossbuild as it was not built on a native arm64 platform.

@CameronNemo
Copy link
Contributor

When building the packages I specified "-a aarch64" to "./xbps-src" to build the packages for arm64. I believe that makes it a crossbuild as it was not built on a native arm64 platform.

Yeah that was a cross build on glibc.

We like to have the commit messages have a specific format. Right now this branch has 8 commits with a lot of merge commits. You should only have two commits (in the same branch/PR), as I mentioned before. Always rebase commits on master, do not merge master into your branch. You should probably review the CONTRIBUTING.md document in this repo.

@ericonr ericonr added the new-package This PR adds a new package label Oct 12, 2021
@CameronNemo
Copy link
Contributor

@tiemenwerkman

Please abstain from temporarily closing a pull request while revising the templates. Instead, leave a comment on the PR describing what still needs work, or add "[WIP]" to the PR title. Only close your pull request if you're sure you don't want your changes to be included.

It is suggested that you keep the same branch name and PR, and just force push to the branch if you are making changes. When you keep closing PRs, it makes the review process more difficult.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new-package This PR adds a new package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants