New package: harvid-0.8.3

[notthewave]

closes #33382
Ardour http video daemon

General

• This is a new package and it conforms to the quality requirements

Have the results of the proposed changes been tested?

I would use this package on a regular basis, but I'm on musl and have trouble patching.
Compiles on glibc but I can't test.

Does it build and run successfully?

(Please choose at least one native build and, if supported, at least one cross build. More are better.)

• I built this PR locally for my native architecture, (ARCH-LIBC)
• I built this PR locally for these architectures (if supported. mark crossbuilds):
  • x86_64-glibc
  • aarch64-musl
  • armv6l-musl

[notthewave]

Error output is different on my local copy of void-packages.

[notthewave]

not sure about the musl patch...

[notthewave]

Not sure why this fails again. Builds just fine on my system with xbps-src.

[notthewave]

To make the video thing work in Ardour one also needs xjadeo. Shall I add it to this PR? Or make a seperate one?

[TinfoilSubmarine]

I think it should be added to this PR as a separate commit.

[TinfoilSubmarine]

Doing a quick diff of a (successful) run on my machine with the logs from the CI run, I saw that it was trying to run make -C libharvid and make -C src at the same time, while locally it ran make -C libharvid fully and then ran make -C src. I wonder if the template needs disable_parallel_build=yes...

Also, I saw that in do_build, it looks for which and git several times. When I added those to hostmakedepends to test, it looked for xxd as well.

[TinfoilSubmarine]

Confirmed on a PR staged against my fork: TinfoilSubmarine#1 and TinfoilSubmarine#4

Only difference between 1 and 4 is that 1 additionally added the 3 packages I mentioned above to hostmakedepends. 4 proves that those are unneeded and the real fix is adding disable_parallel_build=yes.

[notthewave]

Great, that did the trick.

[notthewave]

Now onto xjadeo. I had no luck with installing the static binary in /usr/bin. When launching it from said directory, it complained about not finding a display, but when I ran it with ./, it popped up.

I hope this does not happen when installed with xbps but well see...

[TinfoilSubmarine]

Can you mark WIP and push that commit so we can review and better help?

[notthewave]

Not sure which package is needed for jack.

[notthewave]

Again, different error output.

[notthewave]

checking whether struct tm is in sys/time.h or time.h... time.h
./configure: line 6429: syntax error near unexpected token `JACK,'
./configure: line 6429: `PKG_CHECK_MODULES(JACK, jack, ,'

meanwhile, CI does not even find ./configure

ladish-devel and jack-devel don't seem to help

[TinfoilSubmarine]

Several things:

Just do ./autogen.sh instead of what you currently have in pre_configure(). This fixes the error with missing ./configure.

Also needs pkg-config in hostmakedepends to avoid missing macros in configure.ac.

Having pkg-config installed reveals the necessary makedepends libXpm-devel.

[TinfoilSubmarine]

Also should probably consider some of those optional depends. These ones flipped some stuff in the configuration report:
libltc-devel liblo-devel alsa-lib-devel imlib2-devel

[TinfoilSubmarine]

Regarding the end-game of getting this all working with Ardour:

I was reading this (https://manual.ardour.org/video-timeline/setup/) and saw that it expects ffmpeg_harvid and ffprobe_harvid to point to the system ffmpeg and ffprobe respectively. You should probably add ffmpeg as a runtime dependency (depends="ffmpeg") and create those symlinks in the harvid template.

[notthewave]

Wouldn't it be a more elegant solution if we patch it instead of symlinking FFmpeg and FFprobe?
paper suggested that, under the condition that newest FFmpeg plays nice.

[notthewave]

Just tested with symlinks, works great!

[TinfoilSubmarine]

Wouldn't it be a more elegant solution if we patch it instead of symlinking FFmpeg and FFprobe? paper suggested that, under the condition that newest FFmpeg plays nice.

Agree, would be more elegant. Either way newest FFmpeg would need to play nice since the latest "blessed" version from Ardour is 2.8.2 while Void is currently shipping 4.4.

[notthewave]

So somehow it does not work, maybe I accidentally tested the Flatpak before...
The videoclip is shown in the timeline but xjadeo does not launch.

[notthewave]

Do you use a X windowmanager/desktop env.?
On sway Wayland it reports:

Could not open video output.
Could not open display.

when running xjadeo standalone.

[notthewave]

Just tested with X: same error.
Also tried the static binaries: no luck either.

[TinfoilSubmarine]

I had this running standalone yesterday on sway... Do you have xwayland installed and configured in sway config?

[TinfoilSubmarine]

You might want to rebase on void-packages:master and then try re-building. When I switch to your branch and try to build, it starts building automake; it must have been updated recently. Not sure if that would be causing your issues, but best to make sure.

[notthewave]

Xwayland is enabled, and I rebased on void-packages:master. Still no change.

[notthewave]

Does it work for you in Ardour? Also are you on a glibc system?

[TinfoilSubmarine]

I'm on glibc, so musl may be the issue.

[notthewave]

• Crap I made a mistake and amended changes to the wrong commit. Fixed
• Also just noticed the symlinks don't work...

[TinfoilSubmarine]

Does it work for you in Ardour? Also are you on a glibc system?

I don't actually use ardour, but I will try to install and run on my system if I get a chance.

[TinfoilSubmarine]

Just ran ardour and tried to add a video and activate video monitor. xjadeo popped up for a brief second, then closed.

[TinfoilSubmarine]

harvid is working fine though, if the only thing it is supposed to do is generate the video timeline.

[notthewave]

you can right-click the video and activate xjadeo again (video whatever option).
I think harvid is also responsible for the connection to xjadeo.

[TinfoilSubmarine]

Ok, yeah the window shows back up when I right click on the video. Still no luck with getting it running on musl?

[notthewave]

hold on I'll try

…

On Mon, Oct 25 2021 at 13:07:10 -0700, Joel Beckmeyer ***@***.***> wrote: Ok, yeah the window shows back up when I right click on the video. Still no luck with getting it running on musl? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#33586 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AR3H7HVH7DVMNRWFQH4OV73UIW2G5ANCNFSM5GDPEZAA>. Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[notthewave]

Still same problem.

~ ❱ xjadeo
Could not open video output.
Could not open display.
~ ❱ 

I'll try the maintainers proposed solution

harvid video thumbnails work

[notthewave]

@paper42 can you reproduce on your musl system?

[TinfoilSubmarine]

@notthewave I spun up a x86_64-musl void install and tested, it's working for me. Looks like it might be a system issue/configuration unique to you.

[notthewave]

might have to setup my sytem anew because there seem to be multiple configuration issues. Maybe something is corrupted.

[notthewave]

Alright, I found the issue. Had it installed in /usr/bin/local before packaging and that caused the problem. Now it works without issue.

[notthewave]

Ardour crashes when adjusting the bottom timeline view with harvid activated.
To an extent that ardour (without tinkering) does not open the file anymore.

was caused by something else sorry...

Should be ready for merge.

[github-actions]

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.