Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

radare2: update to 5.4.2, new package: iaito #33608

Closed
wants to merge 2 commits into from

Conversation

heittpr
Copy link
Contributor

@heittpr heittpr commented Oct 17, 2021

General

Have the results of the proposed changes been tested?

  • I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
  • I generally don't use the affected packages but briefly tested this PR

Radare2 was recently forked as rizin, which cutter (the old radare2 GUI) now uses as a backend, making radare2 and cutter incompatible. Cutter was also forked as r2cutter (now rebranded as iaito), to keep compatibility with radare2.

I packaged iaito and made cutter into a subpackage for now, until we decide to package rizin.

@ericonr
Copy link
Member

ericonr commented Oct 20, 2021

common/shlibs should happen in same commit as radare, cutter being replaced with iaito should happen in same commit as well.

@heittpr
Copy link
Contributor Author

heittpr commented Oct 21, 2021

common/shlibs should happen in same commit as radare, cutter being replaced with iaito should happen in same commit as well.

I squashed the commits accordingly.

@ericonr
Copy link
Member

ericonr commented Oct 21, 2021

One issue with the subpackage is that it means packaging cutter in the future will require a bunch of reverts, since the version number for iaito seems to be way ahead of cutter's.

@ericonr
Copy link
Member

ericonr commented Oct 21, 2021

How would you feel about packaging rizin so we can just ship both toolkits and UIs? That would avoid having to deal with this in the future, where it gets more complicated :P

@heittpr
Copy link
Contributor Author

heittpr commented Oct 21, 2021

How would you feel about packaging rizin so we can just ship both toolkits and UIs? That would avoid having to deal with this in the future, where it gets more complicated :P

I guess I could give it a try :~)

It should be really similar to the radare2 package since the fork is relatively recent and thus much of the codebase is actually the same.

@Johnnynator
Copy link
Member

#34221

It should be really similar to the radare2 package since the fork is relatively recent and thus much of the codebase is actually the same.

At least for me auto analysis was extremely slow and unreliable in r2 with at least one case, rizin doesn't have the same problem. (also kinda the reason I never got much into using r2 for like anything).

Could you cleanup the PR to only include iaito as new package and the r2 update?

@ericonr
Copy link
Member

ericonr commented May 13, 2022

Since #35901 has been merged, I think we just need a new iaito package, correct?

#35976 is doing a radare2 update, as well.

@ypsvlq
Copy link
Contributor

ypsvlq commented May 13, 2022

Iaito's last stable release is 1 year old and doesn't build against current r2, and even the beta release is 6 months outdated (though it might still build, I'm not sure).

@ericonr
Copy link
Member

ericonr commented May 14, 2022

Oof, that sucks :/

Would you like to keep the PR open? You can try asking upstream for releases.

@ypsvlq
Copy link
Contributor

ypsvlq commented May 14, 2022

There will be some eventually, I think its just that iaito isn't stable / consistently being worked on yet.

[12:12] pancake: Right now iaito is broken because im waiting to release r2-5.7 which will address the thread handling problems that it have right now

@github-actions
Copy link

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label Aug 13, 2022
@github-actions github-actions bot closed this Aug 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants