Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: activityrelay-0.2.0 #33639

Merged
merged 1 commit into from May 7, 2022
Merged

Conversation

TinfoilSubmarine
Copy link
Contributor

@TinfoilSubmarine TinfoilSubmarine commented Oct 19, 2021

Testing the changes

  • I tested the changes in this PR: YES

New package

LitePub relay from the Pleroma project: https://git.pleroma.social/pleroma/relay

@ericonr ericonr added the new-package This PR adds a new package label Oct 19, 2021
Copy link
Member

@Piraty Piraty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this even usable yet at 0.1.0 ? quick glimpse at their issue tracker reveals lack of fundamental features

srcpkgs/relay/files/relay/run Outdated Show resolved Hide resolved
@TinfoilSubmarine
Copy link
Contributor Author

is this even usable yet at 0.1.0 ? quick glimpse at their issue tracker reveals lack of fundamental features

Yes, I'm running this currently with no issues...

@Piraty Piraty requested a review from ahesford October 22, 2021 23:05
@Duncaen
Copy link
Member

Duncaen commented Oct 23, 2021

They seem to use the name activityrelay and I think even if our policy says to use the upstream name of the repo and distfiles, because this is called just "relay" which is way to generic diverting from the policy and using the more appropriate name is better.

Copy link
Member

@ahesford ahesford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The history for this project extends back several years, but it still seems that it needs to mature before being packaged by Void. I'd at least like to see upstream ship some real entrypoint scripts so that the commands are usable directly.

I also agree with Duncaen that the name, although compliant with our guidance, is too generic here and probably needs to be handled as a special case.

srcpkgs/relay/files/relay/run Outdated Show resolved Hide resolved
@TinfoilSubmarine TinfoilSubmarine changed the title New package: activityrelay-0.1.0 New package: activityrelay-0.2.0 May 6, 2022
@Piraty Piraty merged commit e9170a9 into void-linux:master May 7, 2022
@TinfoilSubmarine TinfoilSubmarine deleted the relay branch August 22, 2022 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-package This PR adds a new package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants