Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gping: update to 1.2.6 #33773

Merged
merged 1 commit into from Oct 30, 2021
Merged

gping: update to 1.2.6 #33773

merged 1 commit into from Oct 30, 2021

Conversation

cinerea0
Copy link
Contributor

General

Have the results of the proposed changes been tested?

  • I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
  • I generally don't use the affected packages but briefly tested this PR

Copy link
Member

@paper42 paper42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't see this update because our update check is broken, would you mind looking into this? Otherwise lgtm, thanks!

@cinerea0
Copy link
Contributor Author

Upstream started naming their releases "gping-${version}" instead of just "${version}" two releases after the last time you updated the package. Since xbps-src update-check is specific when it comes to the URL needed to check for updates, it didn't show anything other than the update to 1.2.1. The distfile now uses upstream's new naming convention, so this problem shouldn't arise again for this package. However, I think there are potentially many more packages with this same problem since the list of available updates at https://alpha.de.repo.voidlinux.org/void-updates/void-updates.txt doesn't include the "NO VERSION found" errors that tipped me off to the exact same name change situation having happened to watchexec.

@paper42
Copy link
Member

paper42 commented Oct 28, 2021

The distfile now uses upstream's new naming convention, so this problem shouldn't arise again for this package.

It is not, you can see the whole list of versions detected by update-check when XBPS_UPDATE_CHECK_VERBOSE=y is set.

Putting pattern="gping-v\K[0-9.]+(?=.tar.gz)" to the update file seems to help.

However, I think there are potentially many more packages with this same problem since the list of available updates at alpha.de.repo.voidlinux.org/void-updates/void-updates.txt doesn't include the "NO VERSION found" errors that tipped me off to the exact same name change situation having happened to watchexec.

That's probably correct and we should fix them when we find them. In this case, versions were detected, but only until 1.2.1.

@cinerea0
Copy link
Contributor Author

@paper42 The update file has been added!

@paper42 paper42 merged commit 8fa6d45 into void-linux:master Oct 30, 2021
@cinerea0 cinerea0 deleted the gping branch October 30, 2021 17:46
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants