Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gifski: update to 1.5.1 #33822

Merged
merged 1 commit into from
Oct 30, 2021
Merged

gifski: update to 1.5.1 #33822

merged 1 commit into from
Oct 30, 2021

Conversation

cinerea0
Copy link
Contributor

General

Have the results of the proposed changes been tested?

  • I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
  • I generally don't use the affected packages but briefly tested this PR

@zdykstra
Copy link
Contributor

I tested this on x86_64/glibc, and like 1.4.3 it's missing the ability to directly convert a video into a gif.

$ gifski --fps 10 -o ~/tmp/doot.gif ~/Downloads/tz56y1O.mp4
error: Video support is permanently disabled in this executable.

To enable video decoding you need to recompile gifski from source with:
cargo build --release --features=video
or
cargo install gifski --features=video

Alternatively, use ffmpeg command to export PNG frames, and then specify
the PNG files as input for this executable. Instructions on https://gif.ski

Running my video through ffmpeg first and then converting the output PNGs to a GIF seems to work, though.

$ gifski --version
gifski 1.5.1

$ ffmpeg -i tz56y1O.mp4 frame%04d.png
....
Input #0, mov,mp4,m4a,3gp,3g2,mj2, from 'tz56y1O.mp4':
...
Output #0, image2, to 'frame%04d.png':
frame=   30 fps=0.0 q=-0.0 Lsize=N/A time=00:00:03.00 bitrate=N/A speed=58.4x
video:4134kB audio:0kB subtitle:0kB other streams:0kB global headers:0kB muxing overhead: unknown

$ gifski -o doot.gif frame*.png
gifski created /home/zdykstra/Downloads/test/doot.gif

$ webify -p doot.gif
https://pastebin.stratumzero.date/u/p/2142e388af/doot.gif

@cinerea0
Copy link
Contributor Author

@zdykstra Yeah, that second way is how I tested it. Would you like me to try compiling it with the --features=video flag and testing that?

@ericonr
Copy link
Member

ericonr commented Oct 30, 2021

#28506 for discussion on the ffmpeg stuff

@ericonr ericonr merged commit 3469fa8 into void-linux:master Oct 30, 2021
@cinerea0 cinerea0 deleted the gif branch October 30, 2021 19:42
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants