nyxt: update to 2.2.2 #33871
nyxt: update to 2.2.2 #33871
Conversation
|
I opened a new pr because I couldn't figure out how to fix the last one |
srcpkgs/nyxt/template
Outdated
| make PREFIX=/usr DESTDIR=${DESTDIR} install | ||
| vlicense licenses/ASSET-LICENSE | ||
| vlicense licenses/SOURCE-LICENSE |
There was a problem hiding this comment.
We prefer tabs, I assume your editor did this automatically, could you fix it? When commiting the change, please use git commit --amend instead of git commit to have just one commit in this PR.
There was a problem hiding this comment.
it isn't, did you git add the files before git commit --amend?
There was a problem hiding this comment.
@paper42 pretty sure i did, hmm, when you say tabs to you mean the actual tab character or will 4 spaces do? Because my editor ive been using inserts 4 spaces on tab
There was a problem hiding this comment.
We want literal tabs, you can use xlint srcpkgs/nyxt/template to check if the style is correct on your own computer.
There was a problem hiding this comment.
@paper42 ok now it's fixed
| wrksrc=nyxt | ||
| version=2.2.2 | ||
| revision=1 | ||
| wrksrc=. |
There was a problem hiding this comment.
=> nyxt-2.2.2_1: cleaning build directory...
rm: refusing to remove '.' or '..' directory: skipping '/builddir/.'
Set create_wrksrc instead.
There was a problem hiding this comment.
So instead of having wrksrc=. or wrksrc=nyxt only have create_wrksrc=nyxt?
| @@ -25,7 +25,6 @@ do_install() { | |||
| vlicense licenses/ASSET-LICENSE | |||
| vlicense licenses/SOURCE-LICENSE | |||
| } | |||
|
|
|||
|
I'm going to close this pr for the time being as a bug was found in nyxt 2.2.2 that makes it very unstable and crash constantly. once 2.2.3 comes out with the patch for the issue I'll submit a new pr with the suggested changes. |
|
You can leave it open so we have a reference for why the new version hasn't been merged yet. |
|
Updated to 2.2.3. |
General
Have the results of the proposed changes been tested?
Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)