Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: qpwgraph-0.0.2 #33926

Closed
wants to merge 1 commit into from
Closed

Conversation

st3r4g
Copy link
Contributor

@st3r4g st3r4g commented Nov 6, 2021

General

Have the results of the proposed changes been tested?

  • I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
  • I generally don't use the affected packages but briefly tested this PR

Screenshot from 2021-11-06 17-24-31

@st3r4g st3r4g force-pushed the qpwgraph branch 2 times, most recently from b6c7fc1 to 3194320 Compare November 6, 2021 13:58
@st3r4g
Copy link
Contributor Author

st3r4g commented Nov 6, 2021

it's still trying to run the target's moc...

@ericonr ericonr added the new-package This PR adds a new package label Nov 8, 2021
Copy link
Member

@ericonr ericonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this bring clear improvements over qjackctl already?

Comment on lines +7 to +8
hostmakedepends="pkg-config qt6-base"
makedepends="qt6-base-devel pipewire-devel"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason to prefer qt6 over qt5?

Copy link
Contributor Author

@st3r4g st3r4g Nov 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not really, I would just stick to what the developer uses regularly, which I think is qt6. But if there are reasons to prefer qt5, it's ok.

srcpkgs/qpwgraph/template Outdated Show resolved Hide resolved
@st3r4g
Copy link
Contributor Author

st3r4g commented Nov 8, 2021

Does this bring clear improvements over qjackctl already?

Mainly the ability to work also for video, also quicker to use (one less click then qjackctl, to open the graph from the floating window).

@ericonr
Copy link
Member

ericonr commented Jan 28, 2022

Merged in #35076, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-package This PR adds a new package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants