OpenRCT2: update to 0.3.5 #33932
Closed
OpenRCT2: update to 0.3.5 #33932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericonr
reviewed
Nov 8, 2021
| CXXFLAGS+=" -DHAVE_IMMINTRIN_H=false -DSDL_DISABLE_IMMINTRIN_H=1 -Wno-old-style-cast" | ||
|
|
||
| if [ "$XBPS_CHECK_PKGS" ]; then | ||
| makedepends+=" gtest-devel" |
There was a problem hiding this comment.
Add to checkdepends directly instead!
There was a problem hiding this comment.
It's already in checkdepends, but the tests when cross-compiling don't compile without this block of the diff.
There was a problem hiding this comment.
You're not supposed to run tests when cross compiling, usually...
|
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't update to the latest
objects, despite new upstream being available, because the CMake definitions still target these old versions, anddo_checkfails (almost every single test, at that) with the new packages.This 0.3.5 build loaded up one of my savegames just fine locally on x86_64-glibc. I was able to x-build for aarch64-musl after applying the
makedependsfix, but don't have a running arm device to test that build on right now.General
Have the results of the proposed changes been tested?