Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bacon: update to 4.4. #33977

Merged
merged 1 commit into from Nov 11, 2021
Merged

bacon: update to 4.4. #33977

merged 1 commit into from Nov 11, 2021

Conversation

Bikutoso
Copy link
Contributor

@Bikutoso Bikutoso commented Nov 9, 2021

General

Have the results of the proposed changes been tested?

  • I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
  • I generally don't use the affected packages but briefly tested this PR

@Bikutoso Bikutoso closed this Nov 9, 2021
@ericonr
Copy link
Member

ericonr commented Nov 9, 2021

Hi, why did you close this?

@Bikutoso
Copy link
Contributor Author

Bikutoso commented Nov 9, 2021

Hi, why did you close this?

Closed it due to the x86_64-musl build error. The problem is way above what I can do.

@ericonr
Copy link
Member

ericonr commented Nov 9, 2021

Feel free to reopen! Add a comment that you need help to solve the problem.

I looked at the build log, you need at least:

if [ "$XBPS_TARGET_LIBC" = musl ]; then
	makedepends+=" musl-fts-devel"
fi

If it errors out, I'd add export LDLIBS="-lfts" inside that block.

@ericonr ericonr reopened this Nov 9, 2021
@Bikutoso Bikutoso force-pushed the bacon-update-4.4 branch 2 times, most recently from ff722c9 to 44fc6e4 Compare November 9, 2021 22:25
@ericonr
Copy link
Member

ericonr commented Nov 10, 2021

I'm trying a local built to see if I can catch something

disable_parallel_build=yes
nocross=yes

if [ "$XBPS_TARGET_LIBC" = musl ]; then
makedepends+=" musl-fts-devel"
export LDLIBS="-lfts"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
export LDLIBS="-lfts"
LDFLAGS="-lfts"

This is one ugly build system lol

Copy link
Contributor Author

@Bikutoso Bikutoso Nov 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to have passed.
I'm a bit worried that it might fail to build later on.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you can tell me some simple steps to use it, I can test locally on musl.

Copy link
Contributor Author

@Bikutoso Bikutoso Nov 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I meant is that I'm worried that it might fail to build after being merged. As I tried to build it in a VM and it ended up with a segfault.

Using it is simple enough. Just run bacon (or bacon.sh?) with the file to make. e.g. bacon hello.bac
Their website has a bunch of example code.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just got a segfault now while trying to build the package D:

You shouldn't need a VM to test things on musl. Just ./xbps-src -m masterdir-musl binary-bootstrap x86_64-musl is enough to create a musl masterdir.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, if it segfaults during the build we can just try again, I have no idea where to even start with investigating it.

Comment on lines 20 to 22
makedepends+=" musl-fts-devel"
LDFLAGS="-lfts"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
makedepends+=" musl-fts-devel"
LDFLAGS="-lfts"
makedepends+=" musl-fts-devel"
depends+=" musl-fts-devel"
LDFLAGS="-lfts"

It's needed for the files it generates!

@ericonr ericonr merged commit 36bc8f8 into void-linux:master Nov 11, 2021
@Bikutoso Bikutoso deleted the bacon-update-4.4 branch November 11, 2021 09:14
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants