New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bacon: update to 4.4. #33977
bacon: update to 4.4. #33977
Conversation
Hi, why did you close this? |
Closed it due to the x86_64-musl build error. The problem is way above what I can do. |
Feel free to reopen! Add a comment that you need help to solve the problem. I looked at the build log, you need at least:
If it errors out, I'd add |
ff722c9
to
44fc6e4
Compare
I'm trying a local built to see if I can catch something |
srcpkgs/bacon/template
Outdated
disable_parallel_build=yes | ||
nocross=yes | ||
|
||
if [ "$XBPS_TARGET_LIBC" = musl ]; then | ||
makedepends+=" musl-fts-devel" | ||
export LDLIBS="-lfts" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
export LDLIBS="-lfts" | |
LDFLAGS="-lfts" |
This is one ugly build system lol
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems to have passed.
I'm a bit worried that it might fail to build later on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you can tell me some simple steps to use it, I can test locally on musl.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What I meant is that I'm worried that it might fail to build after being merged. As I tried to build it in a VM and it ended up with a segfault.
Using it is simple enough. Just run bacon
(or bacon.sh
?) with the file to make. e.g. bacon hello.bac
Their website has a bunch of example code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just got a segfault now while trying to build the package D:
You shouldn't need a VM to test things on musl. Just ./xbps-src -m masterdir-musl binary-bootstrap x86_64-musl
is enough to create a musl masterdir.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, if it segfaults during the build we can just try again, I have no idea where to even start with investigating it.
44fc6e4
to
8acf659
Compare
srcpkgs/bacon/template
Outdated
makedepends+=" musl-fts-devel" | ||
LDFLAGS="-lfts" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makedepends+=" musl-fts-devel" | |
LDFLAGS="-lfts" | |
makedepends+=" musl-fts-devel" | |
depends+=" musl-fts-devel" | |
LDFLAGS="-lfts" |
It's needed for the files it generates!
8acf659
to
be31241
Compare
General
Have the results of the proposed changes been tested?