Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: bitwarden-1.29.1 #33984

Closed
wants to merge 1 commit into from
Closed

Conversation

AI-nsley69
Copy link
Contributor

General

Have the results of the proposed changes been tested?

  • I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
  • I generally don't use the affected packages but briefly tested this PR

@ericonr ericonr added the new-package This PR adds a new package label Nov 9, 2021
maintainer="AI-nsley69 <trainsley69@gmail.com>"
license="GPL-3.0-or-later"
homepage="https://bitwarden.com/"
distfiles="https://github.com/bitwarden/desktop/releases/download/v${version}/Bitwarden-${version}-amd64.deb"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why use the x86_64-only deb? Is it not possible to build from source?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't figure out how to build it from source, the instructions seems like it'll only compile typescript to javascript, then run it through npm run electron.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like they have a build workflow for github ci. maybe that'll shed some light on it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll give it a shot!

@q66 q66 added the electron 🤮 Electron package request label Nov 14, 2021
@github-actions
Copy link

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label Jun 11, 2022
@github-actions github-actions bot closed this Jun 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
electron 🤮 Electron package request new-package This PR adds a new package Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants