Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firefox-esr: update to 91.3.0. #34167

Merged
merged 2 commits into from Nov 28, 2021
Merged

Conversation

jdnumm
Copy link
Contributor

@jdnumm jdnumm commented Nov 20, 2021

Testing the changes:

  • I tested the changes in this PR: briefly

Local build testing:

  • I built this PR locally for my native architecture, x86_64-glibc

Note:

I use the Patches from Thunderbird and sync the template with Firefox.

[skip CI]

@@ -32,4 +32,5 @@ ac_add_options --enable-optimize="$CFLAGS"

ac_add_options --enable-official-branding
ac_add_options --enable-application=browser

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why?

Copy link
Contributor Author

@jdnumm jdnumm Nov 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I sync the files from srcpkgs/firefox so it is easier to diff them in the future.

@abenson
Copy link
Contributor

abenson commented Nov 20, 2021

I would prefer this and the other PR be combined since they need to be synced anyway.

@jdnumm
Copy link
Contributor Author

jdnumm commented Nov 21, 2021

I would prefer this and the other PR be combined since they need to be synced anyway.

I was not sure about this. Is this for other packages as well? Like bundling dependencies?

Some other Questions:

  1. Do i use the [skip CI] wrong? The build process has run and throw some errors.

  2. I saw the srrcpkgs/firefox-esr/update file. How is this generated? And Why?

@Duncaen
Copy link
Member

Duncaen commented Nov 26, 2021

  1. yes it should be [ci skip].
  2. the update file is not generated, its added if ./xbps-src update-check firefox-esr does not correctly find if there is a new release. I.e. to change the pattern or the url where to check for new upstream releases. This update check is also used to generate https://alpha.de.repo.voidlinux.org/void-updates/void-updates.txt.

Generally for firefox updates its good to do also a musl and maybe a cross compiled test build just to make sure, if you don't have the resources I can do that.

@jdnumm
Copy link
Contributor Author

jdnumm commented Nov 28, 2021

@Duncaen if i am helpfull here i will keep this package up to date in the future. But in the moment the whole void package thing is new to me. Anyway i managed to cross compile builds for aarch64-musl, aarch64 and native for x86_64-musl.

./xbps-src -m ~/masterdir-musl binary-bootstrap x86_64-musl
./xbps-src -m ~/masterdir-musl pkg firefox-esr

sudo xbps-install -S cross-aarch64-linux-gnu
./xbps-src -a aarch64 pkg firefox-esr

sudo xbps-install -S cross-aarch64-musl
./xbps-src -a aarch64-musl pkg firefox-esr

@Duncaen
Copy link
Member

Duncaen commented Nov 28, 2021

Ok nice. You don't have to install the cross compilers on the host system, xbps-src installs them into the masterdir.

@Duncaen Duncaen merged commit b916574 into void-linux:master Nov 28, 2021
@jdnumm jdnumm deleted the firefox-esr-91.3.0 branch December 9, 2021 17:00
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants