Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delta: update to 0.10.2 #34291

Merged
merged 1 commit into from
Nov 29, 2021
Merged

delta: update to 0.10.2 #34291

merged 1 commit into from
Nov 29, 2021

Conversation

cinerea0
Copy link
Contributor

Testing the changes

  • I tested the changes in this PR: YES

@ericonr
Copy link
Member

ericonr commented Nov 29, 2021

   Compiling git-delta v0.10.2 (/builddir/delta-0.10.2)
error[E0277]: the trait bound `std::collections::HashSet<std::string::String>: From<[_; 0]>` is not satisfied
   --> src/utils/process.rs:689:46
    |
689 |             Some(CallingProcess::GitGrep(([].into(), [].into())))
    |                                              ^^^^ the trait `From<[_; 0]>` is not implemented for `std::collections::HashSet<std::string::String>`
    |
    = note: required because of the requirements on the impl of `Into<std::collections::HashSet<std::string::String>>` for `[_; 0]`

error[E0277]: the trait bound `std::collections::HashSet<std::string::String>: From<[_; 0]>` is not satisfied
   --> src/utils/process.rs:689:42
    |
689 |             Some(CallingProcess::GitGrep(([].into(), [].into())))
    |                                          ^^^^^^^^^^^^^^^^^^^^^^ the trait `From<[_; 0]>` is not implemented for `std::collections::HashSet<std::string::String>`
    |
    = note: required because of the requirements on the impl of `Into<std::collections::HashSet<std::string::String>>` for `[_; 0]`

error: aborting due to 2 previous errors

For more information about this error, try `rustc --explain E0277`.
error: could not compile `git-delta`

To learn more, run the command again with --verbose.
=> ERROR: delta-0.10.2_1: do_check: '${make_cmd} test --release --target ${RUST_TARGET} ${configure_args} 

tests fail to compile, do you think they are depending on new Rust features we don't have?

@cinerea0
Copy link
Contributor Author

I swear, this happens every time I forget to run xbps-src check locally. Yes, this looks like a guarantee that could be proven by a newer version of the rust compiler. Would you prefer I close this or set to WIP?

@ericonr
Copy link
Member

ericonr commented Nov 29, 2021

It's only check, IMO you can set make_check=no with an appropriate # TODO/FIXME comment

srcpkgs/delta/template Outdated Show resolved Hide resolved
@ericonr
Copy link
Member

ericonr commented Nov 29, 2021

Leave a link so I see the mention on my PR #32555

@ericonr ericonr merged commit 77bd5ec into void-linux:master Nov 29, 2021
@cinerea0 cinerea0 deleted the delta branch November 29, 2021 16:58
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants