python3-bibtexparser: update to 1.2.0.

[jgarte]

Testing the changes

• I tested the changes in this PR: briefly

Local build testing

• I built this PR locally for my native architecture, (x86_64)

[jgarte]

@ericonr

This built locally on my machine and I was able to import the library in a repl.

Not sure what's going on with ci...

[paper42]

let's also add the changelog

changelog="https://raw.githubusercontent.com/sciunto-org/python-bibtexparser/master/CHANGELOG"

cc @xaltsc

[jgarte]

changelog="https://raw.githubusercontent.com/sciunto-org/python-bibtexparser/master/CHANGELOG"

@paper42 Done!

[jgarte]

Hmm, the github UI allows me to add suggestions made by others so they can get there name added to the commit, which is really cool but it doesn't squash those commits together. What do void devs prefer? Are you able to squash the final commit on your end from the web ui?

[jgarte]

subject does not follow CONTRIBUTING.md guildelines

I'm not entirely sure what the above lint warning from github CI means. It happened after I accepted @paper42 suggestion above to add pytest to the template.

[jgarte]

It looks like github web ui duplicated python3-future when I accepted your patch/diff.

[jgarte]

@paper42

I applied your co-authorship manually from my terminal and force pushed. I think all should be good now.

[jgarte]

@paper42 @dotnetfox @ericonr

Tests currently fail for this package because PyPi does not include the test repo.

I can add them if I pull the sources in from the project's github repo.

Would you prefer for me to do that?

@paper42

It looks like tests are run with nose instead of pytest:

https://github.com/NixOS/nixpkgs/blob/nixos-unstable/pkgs/development/python-modules/bibtexparser/default.nix#L24

[paper42]

• switch to the github tarball as and add pytest to checkdepends as I mentioned in python3-bibtexparser: update to 1.2.0. #34299 (comment)
• import this patch to fix the one failing test sciunto-org/python-bibtexparser@5f98bac
• do not override do_check

[jgarte]

• switch to the github tarball as and add pytest to checkdepends as I mentioned in python3-bibtexparser: update to 1.2.0. #34299 (comment)
• import this patch to fix the one failing test sciunto-org/python-bibtexparser@5f98bac
• do not override do_check

@paper42

Does pytest wrap unittest or nosetests? I haven't looked that far at the code.

Answer to self:

https://docs.pytest.org/en/6.2.x/unittest.html

pytest supports running Python unittest-based tests out of the box. It’s meant for leveraging existing unittest-based test suites to use pytest as a test runner and also allow to incrementally adapt the test suite to take full advantage of pytest’s features.

[ericonr]

This should use nosetests3 directly, but it also requires that python3-nose be in checkdepends.

[paper42]

We can run all the tests with pytest if we just remove do_check and add pytest to checkdepends.

[jgarte]

Not sure, when I'll be able to spend time on this one again. If anyone else would like to take it over feel free to.

[github-actions]

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.