Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New package: dendrite-0.6.4 #34358

Merged
merged 1 commit into from Mar 3, 2022
Merged

New package: dendrite-0.6.4 #34358

merged 1 commit into from Mar 3, 2022

Conversation

TinfoilSubmarine
Copy link
Contributor

Testing the changes

  • I tested the changes in this PR: YES

New package

Closes #27818

@ericonr ericonr added the new-package This PR adds a new package label Dec 3, 2021
@TinfoilSubmarine
Copy link
Contributor Author

I trimmed down the list of executables that are actually built since the package was large (~70M) with everything included, and most of the other executables are experiments. Now it is only 22MB, and 62MB installed.

I could also split dendrite-monolith-server and dendrite-polylith-server into separate packages, with a third package for the 3 utilities create-user, generate-config, and generate-keys. However, at this point I don't see a compelling reason for that.

@TinfoilSubmarine TinfoilSubmarine changed the title New package: dendrite-0.5.1 New package: dendrite-0.6 Jan 28, 2022
@TinfoilSubmarine TinfoilSubmarine changed the title New package: dendrite-0.6 New package: dendrite-0.6.2 Feb 4, 2022
@TinfoilSubmarine TinfoilSubmarine changed the title New package: dendrite-0.6.2 New package: dendrite-0.6.3 Feb 10, 2022
jcgruenhage
jcgruenhage suggested changes Feb 12, 2022
View reviewed changes
Copy link
Contributor

@jcgruenhage jcgruenhage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looking good to me, just a few minor concerns around polylith mode.

srcpkgs/dendrite/template Outdated Show resolved Hide resolved
srcpkgs/dendrite/template Outdated Show resolved Hide resolved
paper42
paper42 reviewed Feb 14, 2022
View reviewed changes
srcpkgs/dendrite/files/dendrite-monolith-server/run Outdated Show resolved Hide resolved
srcpkgs/dendrite/template Outdated Show resolved Hide resolved
srcpkgs/dendrite/files/dendrite-monolith-server/run Outdated Show resolved Hide resolved
@TinfoilSubmarine TinfoilSubmarine changed the title New package: dendrite-0.6.3 New package: dendrite-0.6.4 Feb 22, 2022
@paper42 paper42 merged commit ed216f1 into void-linux:master Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paper42 paper42 paper42 left review comments

@jcgruenhage jcgruenhage jcgruenhage approved these changes

Assignees
No one assigned
Labels
new-package This PR adds a new package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Package Request: dendrite
4 participants
@TinfoilSubmarine @jcgruenhage @paper42 @ericonr