[RFC] build-styles/go.sh: run go test -v ${go_project:-go_import_path} in do_check #34496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I thought a majority of packages were rebuilding fine with this. I don't think I have any answer to this good enough to suggest inclusion in the buildstyle at this time so I am closing this.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are 313 build_style=go packages, and currently 8 of them have tests defined in the package template.
I have been testing the go packages with this. So far, I have rebuilt 183 packages and there have been no errors and 64 packages have run tests successfully.
Ideally, more tests would be added (because they are a lot more common on internal libraries than command clients) but this is probably the safest default option.
EDIT: My script was setup wrong and some packages did fail. I am testing with only running tests on packages that have a
go.modand the pass rate is very high. I will see how this goes.