zfs: update to 2.1.2.

[zdykstra]

Testing the changes

• I tested the changes in this PR: YES

[zdykstra]

Tested locally on x86_64 with root-on-ZFS. No issues with kernel 5.10.x, 5.14.x, 5.15.x.

[zdykstra]

Ping @Vaelatern @ahesford

[ericonr]

Test failures on musl are because SEEK_DATA and SEEK_HOLE are defined in glibc headers, but not in musl ones. The values can be had from <linux/fs.h>, but that header brings in a lot of cruft too, idk if it's acceptable for upstream. If musl accepts the constants, we can just use that instead.

[Vaelatern]

This is very brand new, only 2 hours. We prefer to wait at least a few days, so I'll ask that we put this on pause to see if upstream fixes musl.

My zfs-on-root machine is in fact a musl box, so the musl failures obviously are relevant to me :)

[zdykstra]

This is very brand new, only 2 hours. We prefer to wait at least a few days, so I'll ask that we put this on pause to see if upstream fixes musl.

My zfs-on-root machine is in fact a musl box, so the musl failures obviously are relevant to me :)

Yup, just getting the ball rolling. I'm dog-fooding it locally because I live the YOLO lifestyle.

[ericonr]

@Vaelatern fwiw this isn't inhibiting functionality, it's just a test for the mmap issues they had with file seeking. Disabling or fixing the tests should be equivalent, given that almost no one runs them :P

I'm looking into the musl side to see if we can define the constants, otherwise I can open an issue with ZFS upstream.

[ericonr]

https://inbox.vuxu.org/musl/20211217075943.2167-1-ericonr@disroot.org/T/#u

[ahesford]

Even if the musl patch is accepted, the patch would need to be backported to our version indefinitely. Would it be better just to patch the tests here (or disable them)?

Maybe defining these constants in make_build_args is sufficient...

[ericonr]

Fwiw the patch is likely to be accepted, from IRC discussion.

I'm okay with backporting, and we can remove it when updating musl.

[zdykstra]

I've pulled in openzfs/zfs#12891 - upstreams patch-of-choice for the musl build issue.

[ericonr]

LGTM, I can install on musl and reboot to test things.

[Vaelatern]

not opposed to backporting the zfs musl patch to fix this.

[ericonr]

Tested and seems to be working fine here.

Thanks for the update!