Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

capnproto: update to 0.9.1 #34584

Merged
merged 4 commits into from Dec 23, 2021
Merged

Conversation

marmeladema
Copy link
Contributor

Testing the changes

  • I tested the changes in this PR: YES

Local build testing

  • I built this PR locally for my native architecture, x86-64

Copy link
Member

@ericonr ericonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@the-eater and @Vaelatern (I think you used capnproto?)

srcpkgs/capnproto/template Outdated Show resolved Hide resolved
@marmeladema marmeladema force-pushed the capnproto-0.9.1 branch 2 times, most recently from d427d0f to 85819b2 Compare December 19, 2021 18:36
@marmeladema
Copy link
Contributor Author

xbps-src is complaining that some libs are missing from common/shlibs:

=> WARNING: capnproto-0.9.1_1: libcapnp-rpc-0.9.1.so not found in common/shlibs!
=> WARNING: capnproto-0.9.1_1: libkj-async-0.9.1.so not found in common/shlibs!
=> WARNING: capnproto-0.9.1_1: libkj-test-0.9.1.so not found in common/shlibs!
=> WARNING: capnproto-0.9.1_1: libcapnpc-0.9.1.so not found in common/shlibs!
=> WARNING: capnproto-0.9.1_1: libkj-http-0.9.1.so not found in common/shlibs!
=> WARNING: capnproto-0.9.1_1: libcapnp-0.9.1.so not found in common/shlibs!
=> WARNING: capnproto-0.9.1_1: libkj-0.9.1.so not found in common/shlibs!
=> WARNING: capnproto-0.9.1_1: libcapnp-websocket-0.9.1.so not found in common/shlibs!
=> WARNING: capnproto-0.9.1_1: libcapnp-json-0.9.1.so not found in common/shlibs!

i'll push another commit shortly updating the libraries version numbers.

@ericonr
Copy link
Member

ericonr commented Dec 19, 2021

Remember to squash the capnproto commits.

And you need to revbump every package that depends on capnproto. xrevbump "rebuild for capnproto-0.9.1." $(xrevshlib capnproto) or something like that should do it.

@marmeladema marmeladema force-pushed the capnproto-0.9.1 branch 3 times, most recently from 057c807 to 5256f00 Compare December 19, 2021 21:00
@Vaelatern
Copy link
Member

I think this is fine

Copy link
Member

@ericonr ericonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to test things on musl now.

Comment on lines 49 to 52
vmove /usr/lib/libcapnp.so
vmove /usr/lib/libcapnp-rpc.so
vmove /usr/lib/libcapnp-json.so
vmove /usr/lib/libcapnp-websocket.so
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason we just don't do vmove "usr/lib/*.so"?

And please remove the leading slashes from all paths here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just amended what was already there. I am not the official maintainer of the package.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because capnproto has "versions" before the .so instead after e.g.

libkj-async-0.9.1.so

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And please remove the leading slashes from all paths here.

Done

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks eater!

srcpkgs/capnproto/template Outdated Show resolved Hide resolved
srcpkgs/capnproto/template Outdated Show resolved Hide resolved
@ericonr ericonr merged commit 9b9e909 into void-linux:master Dec 23, 2021
@marmeladema marmeladema deleted the capnproto-0.9.1 branch January 3, 2022 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants