Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mpv: add sndio patch #34671

Closed
wants to merge 1 commit into from
Closed

mpv: add sndio patch #34671

wants to merge 1 commit into from

Conversation

@robbie01 robbie01 changed the title add combined sndio patch for mpv from OpenBSD ports mpv: add sndio patch Dec 22, 2021
Duncaen added a commit that referenced this pull request Dec 22, 2021
@robbie01
Copy link
Author

changed the build dependency from "sndio-devel sndio" to just sndio-devel 👍

@ericonr
Copy link
Member

ericonr commented Dec 23, 2021

Would enabling sound via SDL2 be an option? The patch is rather simple but I'd prefer to avoid it, if possible.

@robbie01
Copy link
Author

I can confirm that enabling SDL2 is functional for audio, but with the caveats of needing an xbps-src option of its own (making it no more convenient than ao_sndio for Void users), as well as some sndio users noting AV desync issues with SDL2 in the upstream PR at mpv-player/mpv#9298. I haven't yet tested AV outside of a VM, but I'll report back as soon as I do.

@robbie01
Copy link
Author

Using mpv's default vo_gpu, I'm seeing ~200 ms delay with ao_sdl and no significant delay with ao_sndio.

@robbie01
Copy link
Author

mpv-player/mpv#9298 has been merged into upstream, superseding this patch. Closing as there seems to be a lack of interest in backporting ao_sndio at the moment; I hope to see it enabled by default here at the next release 😄

@robbie01 robbie01 closed this Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants