Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: btop-1.1.3 #34717

Closed
wants to merge 1 commit into from
Closed

New package: btop-1.1.3 #34717

wants to merge 1 commit into from

Conversation

brunorro
Copy link

Testing the changes

  • I tested the changes in this PR: YES

New package

Local build testing

  • I built this PR locally for my native architecture, (x86_64-musl)
  • I built this PR locally for these architectures (if supported. mark crossbuilds):
    • aarch64-musl: NO (should work)
    • armv7l: NO (should work)
    • armv6l-musl: NO (should work)

@paper42
Copy link
Member

paper42 commented Dec 27, 2021

duplicate of #33249

@paper42 paper42 closed this Dec 27, 2021
@KeepBotting
Copy link
Contributor

duplicate of #33249

Is this still a dupe even though it's a newer version? btop would be nice to have. Any particular reason not to merge this or the older PR?

@q66
Copy link
Contributor

q66 commented Dec 27, 2021

this PR does not meet quality criteria (setting archs for no reason, gcc in makedepends, spurious comments, etc) while the other one does

@brunorro
Copy link
Author

It's OK. The important part is getting btop packaged. BTW, could xlint give warnings about quality criteria?

Thank you

@paper42
Copy link
Member

paper42 commented Dec 27, 2021

BTW, could xlint give warnings about quality criteria?

xlint warns about things that make sense, are wrong in all cases and are easily detectable. For example gcc in makedepends might make sense in some cases (not this one), comments are sometimes even required, restricting archs is sometimes necessary, etc.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants