Update granite #34754
Closed
Update granite #34754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TeddyDD
force-pushed
the
update-granite
branch
from
4603bb7
to
3acb11d
Compare
|
Build passed for 4603bb7 (also tested locally), 3acb11d just fixes lint errors. |
TeddyDD
force-pushed
the
update-granite
branch
from
3acb11d
to
a75d85e
Compare
|
Hey, are you still working on this? I could fix up the build issues if that's alright with you. |
|
Go ahead, my PC is currently broken, and I can't work on my PRs until it returns from service. |
Merged
|
done in #36085 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
let's see if ci will timeout, hopefully not
Testing the changes
Local build testing