Fix syntax #34760
Closed
Fix syntax #34760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
get rid of extra prosses 'cat' and use builtin bash commands fix some bash syntax (using sh syntax in a bash script)
sgn
reviewed
Dec 30, 2021
Comment on lines
-12
to
+14
| cat << _EOF | ||
| while read ; do | ||
| printf "%s\n" "$REPLY" | ||
| done <<- _EOF |
There was a problem hiding this comment.
cat is fine here, beside a short and rare usage of usage, cat is easier to reason about.
There was a problem hiding this comment.
why using something outside bash if it have the solution
|
Nothing's broken, those are just style adjustments. |
that what i said on my pull request description |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get rid of extra prosses 'cat' and use builtin bash commands fix some bash syntax (using sh syntax in a bash script)