mixxx: update to 2.3.3. #34808
Merged
mixxx: update to 2.3.3. #34808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prez
force-pushed
the
mixxx
branch
2 times, most recently
from
26ab7f6
to
9a9f4b9
Compare
|
Pinging the maintainer, @Gottox |
|
No response from @Gottox in over 2 1/2 months. Claiming maintainership. |
|
I just built this locally, it seems to work, would be great to have it finally merged; could you please rebase it against the current master so that CI passes and perhaps rename the GitHub PR title to match the commit title? |
|
@Johnnynator you've merged a mixxx PR in the past, can I ask you to please review and merge this too? |
|
Could you rebase again on the latest master @prez? I tried the failing builds locally and they somehow work so yeah, worth another try |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing the changes
Local build testing