gettext: fix cross compile #34866
Closed
gettext: fix cross compile #34866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For gettext-0.21 cross-compile does not work, because the
pre-configure step tries to run `autoreconf -fi`, which fails with the
error
configure.ac:25: error: AC_INIT should be called with package
and version arguments
: gl_AM_INIT_AUTOMAKE is expanded from...
/usr/share/aclocal-1.16/init.m4:29: AM_INIT_AUTOMAKE is expanded from...
configure.ac:25: the top level
autom4te: /usr/bin/m4 failed with exit status: 1
aclocal: error: /usr/bin/autom4te failed with exit status: 1
autoreconf: aclocal failed with exit status: 1
This pre-configure step was added back in commit 17f6ad8 for
gettext-0.18.3, but its not clear what the error seen back then was, and
now cross-compiling without running autoreconf works fine.
So this commit just removes the pre-configure step, reverting 17f6ad8.
lfdebrux
force-pushed
the
fix-gettext-cross
branch
from
2d4c6cf
to
9cce4e5
Compare
Oh, that's interesting, nice find! Forgive my ignorance, but what's the advantage of running autoreconf before cross-compiling? |
|
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For gettext-0.21 cross-compile does not work, because the pre-configure step tries to run
autoreconf -fi, which fails with the errorThis pre-configure step was added back in commit 17f6ad8 for gettext-0.18.3, but its not clear what the error seen back then was, and now cross-compiling without running autoreconf works fine.
So this PR just removes the pre-configure step, reverting 17f6ad8. This fixes #34810.
Testing the changes
Local build testing