Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fail2ban: add patch for python 3.10. #35123

Merged
merged 1 commit into from Jan 20, 2022
Merged

fail2ban: add patch for python 3.10. #35123

merged 1 commit into from Jan 20, 2022

Conversation

ftpd
Copy link
Contributor

@ftpd ftpd commented Jan 19, 2022

This minor change fixes fail2ban against python 3.10.

Testing the changes

  • I tested the changes in this PR: YES

Local build testing

  • I built this PR locally for my native architecture, x86-glibc.

@Duncaen
Copy link
Member

Duncaen commented Jan 19, 2022

The commit title should reflect the changes, since this is not really an update.

@ftpd
Copy link
Contributor Author

ftpd commented Jan 19, 2022

@Duncaen that's why I've put _3 there (the current revision is _2). If it's not enough, what action should I take to fix it?

@Duncaen
Copy link
Member

Duncaen commented Jan 19, 2022

Its not enough, thats useless information, it tells us nothing, revision increases usually have a reason, be it rebuilds for updated dependencies or patches, but its important to document that reason in the commit message.

@ftpd
Copy link
Contributor Author

ftpd commented Jan 19, 2022

I've put the reason in the first comment of this PR.

Sure, I will change the message if it's still possible now. Can simple --amend do this?

@ftpd ftpd changed the title fail2ban: update to 0.11.2_3. fail2ban: update revision to 0.11.2_3 to make it work with python 3.10. Jan 19, 2022
@ftpd
Copy link
Contributor Author

ftpd commented Jan 19, 2022

I've changed the title of the PR, that's the thing I could do for now. Please tell me how to change commit message and I'll gladly do it.

Copy link
Member

@paper42 paper42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • git --amend the commit message and add more information about this change
  • use an email address associated with your github account for the commit, so we can easily see in the github UI who created the commit
  • I think you got this patch from somewhere, could you include it whole including the commit message (as you downloaded it from their github/lab without any changes)?
  • rename the patch to python3.10.patch

@ftpd ftpd changed the title fail2ban: update revision to 0.11.2_3 to make it work with python 3.10. fail2ban: add patch for python 3.10. Jan 20, 2022
@paper42 paper42 merged commit d14d3ea into void-linux:master Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants