Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flameshot: update to 11.0.0 #35194

Merged
merged 1 commit into from Jan 23, 2022
Merged

flameshot: update to 11.0.0 #35194

merged 1 commit into from Jan 23, 2022

Conversation

prateekmedia
Copy link
Contributor

Testing the changes

  • I tested the changes in this PR: briefly

@oreo639
Copy link
Member

oreo639 commented Jan 23, 2022

Again, it needs to be <pkgname>: update to <version> with pkgname being the same case as the package name (in this case all lowercase) and version being the package version as described in the template without any other extra identifiers (i.e. no v)
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md

As the contributing guide mentions in the Review section, just use git commit --amend to update the commit message.

@prateekmedia
Copy link
Contributor Author

@oreo639 Done! I was not cloning the repo cause it was more than 400Mb in size, but anyways.

@paper42
Copy link
Member

paper42 commented Jan 23, 2022

Done! I was not cloning the repo cause it was more than 400Mb in size, but anyways.

If you didn't clone this repository, how did you test this package? We generally require build and runtime testing.

@prateekmedia
Copy link
Contributor Author

prateekmedia commented Jan 23, 2022

Done! I was not cloning the repo cause it was more than 400Mb in size, but anyways.

If you didn't clone this repository, how did you test this package? We generally require build and runtime testing.

I was using git clone --depth 1 before so it was 12 MB in size + vpsm to build package.

@paper42
Copy link
Member

paper42 commented Jan 23, 2022

great, the commit message still needs to be fixed, is not v11.0.0, but 11.0.0

@prateekmedia prateekmedia changed the title Update Flameshot to v11.0.0 flameshot: update to 11.0.0 Jan 23, 2022
@prateekmedia
Copy link
Contributor Author

@oreo639 It is passing all test, what next?

@oreo639
Copy link
Member

oreo639 commented Jan 23, 2022

That's it. Just be patient.

@paper42 paper42 merged commit 03ecd6a into void-linux:master Jan 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants