-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: julia: update to 1.7.1. #35270
WIP: julia: update to 1.7.1. #35270
Conversation
thanks for doing the hard work on this, as a void julia user, i appreciate it! ❤️ |
please take care of #35270 |
libblastrampoline's tests require julia which would result in cyclic dependency, maybe put a comment ? |
also, JuliaLinearAlgebra/libblastrampoline@39d859e is interesting (though appears not entirely correct for the static lib) |
Looks like you linked the wrong issue/PR. |
Where I'm stuck at with this right now is that julia's build system seems to want to build all dependencies regardless of which |
cb575ac
to
72a45c9
Compare
This needs to be separated out into two commits: one for the new libblastrampoline package.
This appears to be some sort of issue with an interaction between the xbps-src system and julia's build system. Invoking Any thoughts @ahesford since you have some level of familiarity with this template? |
I've attempted to take a look at this and tried to build it by hand (manually running I'm not sure why--my best attempt at reading the Makefile to figure out what's happening seems to point to it using
which suggests something additionally may be broken with the current state of the libblastrampoline package. I doubt that's the same issue @non-Jedi you're facing with the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, I haven't had any time to look at the build problems here and am not sure when I'll have some spare time to dig in. The few points I make below are based just on reading the template and not actually trying to build it.
make_install_args="$make_build_args" | ||
make_check_args="$make_build_args" | ||
make_check_target=testall | ||
conf_files="/etc/julia/startup.jl" | ||
hostmakedepends="pkg-config perl cmake python gcc-fortran patchelf which tar xz" | ||
hostmakedepends="pkg-config perl cmake python3 gcc-fortran patchelf which tar xz libwhich" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if libwhich
here is complicating the search for libraries in a way that triggers vendored builds of libraries you've installed in makedepends
.
makedepends="p7zip pcre2-devel mpfr-devel libgit2-devel libcurl-devel nghttp2-devel | ||
libssh2-devel mbedtls-devel libatomic-devel zlib-devel libunwind-devel | ||
libutf8proc-devel" | ||
libutf8proc-devel libblastrampoline-devel openblas-devel" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mentioned "vendored builds" below; what is the purpose for pulling openblas-devel
here if a vendored build will be done?
nocross="build system is a mess" | ||
noverifyrdeps="Julia doesn't need to depend on system llvm/openblas with vendored builds in /usr/lib/julia/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a pretty big hammer and can often lead to dependency problems. Can this be replaced with a skiprdeps
list that explicitly exempts only those files that trigger erroneous dependency resolution?
I was messing with julia on musl, I don't know what you guys are using but, at least for me, the void package appears to work but doesn't (it segfaults when trying to add new julia packages). So I tried their official musl binary that doesn't even work either until I settled for compiling it myself which has given me the best result so far I haven't run into any issue with dependent on julia. The relevancy into this issue is one, there is already a 1.7.2 release and soon to come out 1.8.0 and second could it be possible to export or reverse engineer the flags used by make "by default" so we can use them for the template? I also attempted to make a template, but it just didn't work at all, like just changing the version and the checksums broke it all. |
oh, i meant to link #34387 |
ping |
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it. |
* FTBFS: void-linux#34387 * unmaintained: void-linux#35270 * blocks libgit2 update
* FTBFS: void-linux#34387 * unmaintained: void-linux#35270 * blocks libgit2 update
closing, see #39919 |
* FTBFS: void-linux#34387 * unmaintained: void-linux#35270 * blocks libgit2 update
Still need to finish building/testing locally and separating out into logical commits, but I thought I should put this here to make sure there's no duplicated effort since I'm not sure when I'll finish this up, and libblastrampoline was annoying to get to build correctly.
[ci skip] for building llvm.
Testing the changes