Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: docker-cli-compose-2.2.3 #35362

Closed
wants to merge 2 commits into from

Conversation

paper42
Copy link
Member

@paper42 paper42 commented Feb 2, 2022

Testing the changes

  • I tested the changes in this PR: briefly

@paper42 paper42 changed the title docker-compose: update to 2.2.3. New package: docker-cli-compose-2.2.3 Feb 4, 2022
@paper42
Copy link
Member Author

paper42 commented Feb 5, 2022

This needs more investigation, marking as draft for now

@paper42 paper42 marked this pull request as draft February 5, 2022 01:01
@ericonr ericonr added the new-package This PR adds a new package label Feb 5, 2022
@paper42 paper42 closed this in bf7aa5b Feb 10, 2022
@dm17
Copy link

dm17 commented Feb 11, 2022

Looks like docker compose (aka compose v2) has compose v1 compatibility on Arch (by running the old "docker-compose"), but not on Void. I'm also wondering how
du -sh /usr/libexec/docker/cli-plugins/docker-compose could return 8.6M on Void while du -sh /usr/lib/docker/cli-plugins/docker-compose could return 31M on Arch. That seems like more of a size difference than the wrapper/helper for backward compatibility could account.
Thanks a bunch!

@paper42
Copy link
Member Author

paper42 commented Feb 11, 2022

Looks like docker compose (aka compose v2) has compose v1 compatibility on Arch (by running the old "docker-compose"), but not on Void.

If you look at this PR, it was closed by bf7aa5b, I decided to go with just updating the package and not creating a new one. We also have a wrapper.

I'm also wondering how

du -sh /usr/libexec/docker/cli-plugins/docker-compose could return 8.6M on Void while du -sh /usr/lib/docker/cli-plugins/docker-compose could return 31M on Arch. That seems like more of a size difference than the wrapper/helper for backward compatibility could account.

I am not sure how you measured this, I see 21MB on aarch64-musl and 13MB on x86_64. I think it's because of stripping, but I am not sure if the difference is this big and if arch doesn't strip go programs.

EDIT: the size reported by ls is actually 25MB, du reports disk usage

@dm17
Copy link

dm17 commented Feb 11, 2022

Looks like docker compose (aka compose v2) has compose v1 compatibility on Arch (by running the old "docker-compose"), but not on Void.

If you look at this PR, it was closed by bf7aa5b, I decided to go with just updating the package and not creating a new one. We also have a wrapper.

I'm also wondering how

du -sh /usr/libexec/docker/cli-plugins/docker-compose could return 8.6M on Void while du -sh /usr/lib/docker/cli-plugins/docker-compose could return 31M on Arch. That seems like more of a size difference than the wrapper/helper for backward compatibility could account.

I am not sure how you measured this, I see 21MB on aarch64-musl and 13MB on x86_64. I think it's because of stripping, but I am not sure if the difference is this big and if arch doesn't strip go programs.

EDIT: the size reported by ls is actually 25MB, du reports disk usage

Ah thanks du vs ls shows much less of a difference :)

We also have a wrapper.

How is this evoked? docker-compose disable-v2 doesn't seem to work.

@paper42
Copy link
Member Author

paper42 commented Feb 11, 2022

We also have a wrapper.

How is this evoked? docker-compose disable-v2 doesn't seem to work.

The wrapper I am talking about is /usr/bin/docker-compose, it should be compatible with v1. disable-v2 is an development command and was probably dropped.

@dm17
Copy link

dm17 commented Feb 11, 2022

Nice! So both v1 & v2 seem to be working correctly on void now. And I now realize the standard v1 vs v2 differentiation (across distros) is "docker-compose" vs "docker compose" - thanks!

ElDifinitivo pushed a commit to ElDifinitivo/void-packages that referenced this pull request Feb 14, 2022
ElDifinitivo pushed a commit to ElDifinitivo/void-packages that referenced this pull request Feb 14, 2022
maciozo pushed a commit to maciozo/void-packages that referenced this pull request Feb 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-package This PR adds a new package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants