Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

services fixes - enhancements #35384

Closed
wants to merge 9 commits into from
Closed

services fixes - enhancements #35384

wants to merge 9 commits into from

Conversation

mobinmob
Copy link
Contributor

@mobinmob mobinmob commented Feb 3, 2022

Testing the changes

  • I tested the changes in this PR: YES

@mobinmob
Copy link
Contributor Author

mobinmob commented Feb 3, 2022 •
edited
Loading

vault service:

  • Use a config file with the -c switch instead of a directory.
  • Provide a sample configuration file with the bare minimum the service needs to run (a file storage backend).
  • Create a log service with vlogger.

@paper42
@the-maldridge

@mobinmob
monkey: add log service.
3bc0c36 
Also:
- add redirection to the service script
- remove the pid configuration option,
as it contributes to a wrong conf file.
@mobinmob mobinmob mentioned this pull request Feb 5, 2022
Merged
@mobinmob
thermald: add log service, fix logging.
3d984ad 
Also:
- fix xlint warnings.
@mobinmob mobinmob changed the title [wip] services fixes - enhancements services fixes - enhancements Feb 5, 2022
@mobinmob mobinmob closed this May 28, 2022
@mobinmob mobinmob deleted the service-fixes branch May 28, 2022 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@mobinmob