Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crun: update to 1.4.2. #35388

Closed
wants to merge 1 commit into from
Closed

crun: update to 1.4.2. #35388

wants to merge 1 commit into from

Conversation

natrys
Copy link
Contributor

@natrys natrys commented Feb 3, 2022

Testing the changes

  • I tested the changes in this PR: YES

paper42
paper42 reviewed Feb 4, 2022
View reviewed changes
Copy link
Member

@paper42 paper42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we replace do_check() with make_check=extended?

@natrys
Copy link
Contributor Author

natrys commented Feb 5, 2022

@paper42 don't think that's semantically equivalent. If I remember, it was done like this mostly to stop tests from running in CI (they don't even work locally because of chroot), and probably because ci-skip wasn't a thing yet. So I would think equivalent would be make_check=ci-skip altogether, should I do that instead?

@paper42
Copy link
Member

paper42 commented Feb 5, 2022

they don't even work locally because of chroot

Then we need to fix them, skip some of them or disable them.

@leahneukirchen
Copy link
Member

4242fb7

@natrys natrys deleted the crun-1.4.2 branch July 20, 2022 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paper42 paper42 paper42 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@natrys @paper42 @leahneukirchen