Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inkscape: update to 1.2.2 #35454

Closed
wants to merge 1 commit into from
Closed

inkscape: update to 1.2.2 #35454

wants to merge 1 commit into from

Conversation

hervyqa
Copy link
Contributor

@hervyqa hervyqa commented Feb 7, 2022 •
edited

add python3-cssselect to open "Manage Extensions" dialog.

Testing the changes

  • I tested the changes in this PR: YES

Local build testing

  • I built this PR locally for my native architecture, (x86_64, x86_64-musl)

1.1.2 (x86_64)

image

Update:

1.2.1 (x86_64)

Screenshot_20220518_144113

1.2.1 (x86_64-musl)

Screenshot_20220518_090746

@hervyqa
Copy link
Contributor Author

hervyqa commented Feb 7, 2022

Success, except x86_64-musl.
cc @ericonr

@notthewave notthewave mentioned this pull request Feb 14, 2022
Closed
@tibequadorian
Copy link
Contributor

https://gitlab.com/inkscape/inkscape/-/issues/2241

@hervyqa
Copy link
Contributor Author

hervyqa commented Feb 23, 2022 •
edited

https://gitlab.com/inkscape/inkscape/-/issues/2241

yes, I already know about this issue. previous versions of inkscape also failed on the x86_64-musl (#34478), but it was merged.

@hervyqa
Copy link
Contributor Author

hervyqa commented Feb 23, 2022

or maybe it's better to wait for the final 1.2 release as well this march.

@hervyqa hervyqa changed the title inkscape: update to 1.1.2 inkscape: update to 1.2 May 18, 2022
@hervyqa hervyqa force-pushed the inkscape branch 2 times, most recently from 4f7c02d to 96071f3 Compare May 18, 2022 04:12
@hervyqa
Copy link
Contributor Author

hervyqa commented May 18, 2022 •
edited

Test error. Need help :)

i686

The following tests FAILED:
	 30 - test_lpe (Failed)
Errors while running CTest
ninja: build stopped: subcommand failed.
=> ERROR: inkscape-1.2_1: do_check: '${make_check_pre} ${make_cmd} ${make_check_args} ${make_check_target}' exited with 1
=> ERROR:   in do_check() at common/build-style/cmake.sh:119
Error: Process completed with exit code 1.

x86_64

The following tests FAILED:
	 30 - test_lpe (Failed)
Errors while running CTest
ninja: build stopped: subcommand failed.
=> ERROR: inkscape-1.2_1: do_check: '${make_check_pre} ${make_cmd} ${make_check_args} ${make_check_target}' exited with 1
=> ERROR:   in do_check() at common/build-style/cmake.sh:119
Error: Process completed with exit code 1.

x86_64-musl

The following tests FAILED:
	  3 - test_drag-and-drop-svgz (SEGFAULT)
	 25 - test_svg-extension (SEGFAULT)
	 30 - test_lpe (SEGFAULT)
	 31 - test_lpe64 (SEGFAULT)
Errors while running CTest
ninja: build stopped: subcommand failed.
=> ERROR: inkscape-1.2_1: do_check: '${make_check_pre} ${make_cmd} ${make_check_args} ${make_check_target}' exited with 1
=> ERROR:   in do_check() at common/build-style/cmake.sh:119
Error: Process completed with exit code 1.

@ericonr
Copy link
Member

ericonr commented May 19, 2022

hmm, nice that they managed to fix most of the segfaults on musl

I guess we need to report test_lpe to upstream, probably. Or try to look at what it does.

@ericonr ericonr self-assigned this May 19, 2022
@hervyqa
Copy link
Contributor Author

hervyqa commented May 20, 2022

I guess we need to report test_lpe to upstream, probably. Or try to look at what it does.

LPE (Live Path Effect) is used to manipulate path objects easily. There are many types of LPE, but in this LPE test does not mention which LPE failed to be tested.

The following tests FAILED:
	 30 - test_lpe (Failed)

Maybe one of them failed the test, but I don't know which one.

Screenshot_20220520_112858

source: https://gitlab.com/inkscape/inkscape/-/blob/master/testfiles/src/lpe-test.cpp

// A) FILE BASED TESTS
// TEST_F(LPETest, Bool_multi_px_1_1)                          { run(); }
// TEST_F(LPETest, Bool_multi_mm_1_1)                          { run(); }
TEST_F(LPETest, AttachPath_0_92_5_mixed)                    { run(); }
TEST_F(LPETest, AttachPath_mm_1_0_2)                        { run(); }
TEST_F(LPETest, AttachPath_px_1_0_2)                        { run(); }
TEST_F(LPETest, BoundingBox_mixed_0_92_5)                   { run(); }
TEST_F(LPETest, BoundingBox_mm_1_0_2)                       { run(); }
TEST_F(LPETest, BoundingBox_px_1_0_2)                       { run(); }
TEST_F(LPETest, CloneOriginal_mixed_0_92_5)                 { run(); }
// linked item is broken in 1.0.2 because group cliboard items, use same version of 1.1 but resaved in 1.2 to get comapat in 1.0.1 or before the group clipboard is added
TEST_F(LPETest, CloneOriginal_boken_1_0_2)                  { run(); }
TEST_F(LPETest, CloneOriginal_mixed_px_1_1)                 { run(); }
TEST_F(LPETest, CloneOriginal_mixed_mm_1_1)                 { run(); }
TEST_F(LPETest, ConstructGrid_mixed_0_92_5)                 { run(); }
TEST_F(LPETest, ConstructGrid_mm_1_0_2)                     { run(); }
TEST_F(LPETest, ConstructGrid_px_1_0_2)                     { run(); }
TEST_F(LPETest, Transform2Points_path_0_92_5)               { run(); }
TEST_F(LPETest, Transform2Points_multi_px_1_0_2)            { run(); }
TEST_F(LPETest, Transform2Points_multi_mm_1_0_2)            { run(); }
TEST_F(LPETest, VonCoch_path_0_92_5)                        { run(); }
TEST_F(LPETest, VonCoch_multi_px_1_0_2)                     { run(); }
TEST_F(LPETest, VonCoch_multi_mm_1_0_2)                     { run(); }
TEST_F(LPETest, StitchSubPaths_path_0_92_5)                 { run(); }
TEST_F(LPETest, StitchSubPaths_multi_px_1_0_2)              { run(); }
TEST_F(LPETest, StitchSubPaths_multi_mm_1_0_2)              { run(); }
TEST_F(LPETest, Spiro_mixed_0_92_5)                         { run(); }
TEST_F(LPETest, Spiro_mm_1_0_2)                             { run(); }
TEST_F(LPETest, Spiro_px_1_0_2)                             { run(); }
TEST_F(LPETest, Slice_multi_px_1_1)                         { run(); }
TEST_F(LPETest, Slice_multi_mm_1_1)                         { run(); }
TEST_F(LPETest, Simplify_path_0_92_5)                       { run(); }
TEST_F(LPETest, Simplify_multi_px_1_0_2)                    { run(); }
TEST_F(LPETest, Simplify_multi_mm_1_0_2)                    { run(); }
TEST_F(LPETest, ShowHandles_path_0_92_5)                    { run(); }
TEST_F(LPETest, ShowHandles_multi_px_1_0_2)                 { run(); }
TEST_F(LPETest, ShowHandles_multi_mm_1_0_2)                 { run(); }
TEST_F(LPETest, Ruler_path_0_92_5)                          { run(); }
TEST_F(LPETest, Ruler_multi_px_1_0_2)                       { run(); }
TEST_F(LPETest, Ruler_multi_mm_1_0_2)                       { run(); }
TEST_F(LPETest, RoughHatches_path_0_92_5)                   { run(); }
TEST_F(LPETest, RoughHatches_multi_px_1_0_2)                { run(); }
TEST_F(LPETest, RoughHatches_multi_mm_1_0_2)                { run(); }
// Rougen Test till 1.1 fail because wrong implementation of rand on the LPE
TEST_F(LPETest, Roughen_path_1_1)                           { run(); }
TEST_F(LPETest, EllipseFromPoints_multi_px_1_0_2)           { run(); }
TEST_F(LPETest, EllipseFromPoints_multi_mm_1_0_2)           { run(); }
TEST_F(LPETest, PowerMask_multi_px_1_0_2)                   { run(); }
TEST_F(LPETest, PowerMask_multi_mm_1_0_2)                   { run(); }
TEST_F(LPETest, PowerClip_multi_px_1_0_2)                   { run(); }
TEST_F(LPETest, PowerClip_multi_mm_1_0_2)                   { run(); }
TEST_F(LPETest, PerspectiveEnvelope_mixed_0_92_5)           { run(); }
TEST_F(LPETest, PerspectiveEnvelope_multi_mm_1_0_2)         { run(); }
TEST_F(LPETest, PerspectiveEnvelope_multi_px_1_0_2)         { run(); }
TEST_F(LPETest, Offset_multi_px_1_0_2)                      { run(); }
TEST_F(LPETest, Offset_multi_mm_1_0_2)                      { run(); }
TEST_F(LPETest, Offset_multi_px_1_1)                        { run(); }
TEST_F(LPETest, MirrorSymmetry_path_0_92_5)                 { run(); }
TEST_F(LPETest, MirrorSymmetry_multi_px_1_0_2)              { run(); }
TEST_F(LPETest, MirrorSymmetry_multi_mm_1_0_2)              { run(); }
TEST_F(LPETest, MeasureSegments_multi_px_1_0_2)             { run(); }
TEST_F(LPETest, MeasureSegments_multi_mm_1_0_2)             { run(); }
TEST_F(LPETest, Lattice2_path_0_92_5)                       { run(); }
TEST_F(LPETest, Lattice2_multi_px_1_0_2)                    { run(); }
TEST_F(LPETest, Lattice2_multi_mm_1_0_2)                    { run(); }
TEST_F(LPETest, Knot_path_0_92_5)                           { run(); }
TEST_F(LPETest, Knot_multi_px_1_0_2)                        { run(); }
TEST_F(LPETest, Knot_multi_mm_1_0_2)                        { run(); }
TEST_F(LPETest, JoinType_multi_px_1_0_2)                    { run(); }
TEST_F(LPETest, JoinType_multi_mm_1_0_2)                    { run(); }
TEST_F(LPETest, Interpolate_path_0_92_5)                    { run(); }
TEST_F(LPETest, Interpolate_multi_px_1_0_2)                 { run(); }
TEST_F(LPETest, Interpolate_multi_mm_1_0_2)                 { run(); }
TEST_F(LPETest, InterpolatePoints_path_0_92_5)              { run(); }
TEST_F(LPETest, InterpolatePoints_multi_px_1_0_2)           { run(); }
TEST_F(LPETest, InterpolatePoints_multi_mm_1_0_2)           { run(); }
TEST_F(LPETest, Gears_path_0_92_5)                          { run(); }
TEST_F(LPETest, Gears_multi_px_1_0_2)                       { run(); }
TEST_F(LPETest, Gears_multi_mm_1_0_2)                       { run(); }
TEST_F(LPETest, FilletChamfer_multi_px_1_0_2)               { run(); }
TEST_F(LPETest, FilletChamfer_multi_mm_1_0_2)               { run(); }
// NEED to test on 0.92 no working one here (gnome 40)
// TEST_F(LPETest, FillBetweenStrokes_path_0_92_5)          { run(); }
TEST_F(LPETest, FillBetweenStrokes_path_multi_px_1_0_2)     { run(); }
TEST_F(LPETest, FillBetweenStrokes_path_multi_mm_1_0_2)     { run(); }
// NEED to test on 0.92 no working one here (gnome 40)
// TEST_F(LPETest, FillBetweenMany_multi_0_92_5)               { run(); }
TEST_F(LPETest, FillBetweenMany_multi_px_1_0_2)             { run(); }
TEST_F(LPETest, FillBetweenMany_multi_mm_1_0_2)             { run(); }
TEST_F(LPETest, Ellipse5pts_path_0_92_5)                    { run(); }
TEST_F(LPETest, Ellipse5pts_ellipse_px_1_0_2)               { run(); }
TEST_F(LPETest, Ellipse5pts_ellipse_mm_1_0_2)               { run(); }
TEST_F(LPETest, DashedStroke_multi_px_1_0_2)                { run(); }
TEST_F(LPETest, DashedStroke_multi_mm_1_0_2)                { run(); }
TEST_F(LPETest, RotateCopies_multi_mm_1_0_2)                { run(); }
TEST_F(LPETest, RotateCopies_multi_px_1_0_2)                { run(); }

@ericonr
Copy link
Member

ericonr commented May 21, 2022 •
edited

9ac33cf removed python3-lockfile, we can't depend on it (or at least not without reintroducing it)

https://pypi.org/project/lockfile/ says it's deprecated.

@hervyqa
Copy link
Contributor Author

hervyqa commented May 21, 2022 •
edited

I just found out python3-lockfile is included in the removed packages. But it is necessary to open extension> management extension. Alright, I delete the dependencies. I think the extension is lacking.

Screenshot_20220522_061906

@ericonr
Copy link
Member

ericonr commented May 22, 2022

IMO, if you're up for it, we can add the package back, just need to increase the revision. Or ask inkscape to not depend on a deprecated package.

@hervyqa
Copy link
Contributor Author

hervyqa commented May 23, 2022 •
edited

Still waiting for a reply from the Inkscape developer (issue).
So far the performance version 1.2 is far better than before.

@ericonr
Copy link
Member

ericonr commented May 25, 2022

At least the LPE test specifically seems to be the same issue plaguing other tests on musl, from my debugging. I guess I should have tested on glibc instead.

@hsnfirdaus
Copy link
Contributor

Screenshot from 2022-05-27 22-12-11
Out of topic, Why my inkscape appmenu is duplicated? is inkscape bug, void linux bug or something wrong with my system? Void Linux x86_64
I try built myself inkscape 1.2 from this template...

@hervyqa
Copy link
Contributor Author

hervyqa commented May 27, 2022

seems fine.
Screenshot_20220528_015113

@hervyqa
Copy link
Contributor Author

hervyqa commented May 31, 2022 •
edited

Maintainer says:

There's two separate issues: we don't package lockfile, because it's not a dependency of cachecontrol (it's only an optional depencency: https://github.com/ionrock/cachecontrol/blob/f93d8af93e6dcc98f6867d2a09d4f68f6acc135f/setup.py#L25). So lockfile needs to be added to pyproject.toml @pulsar17.

Also lockfile is deprecated (psf/cachecontrol#109) and hasn't been replaced in cachecontrol since 2016.

Currently there is no need to add python3-lockfile, because the package is only optional and even then deprecated. means that inkscape 1.2 is now intentionally not fully supported for extensions manager.

But that's okay, because adding extensions can still be done manually by adding to ~/.config/inkscape/extensions/

Cc @ericonr

@hervyqa hervyqa force-pushed the inkscape branch 4 times, most recently from 90e08c4 to 4069b71 Compare June 23, 2022 11:59
ericonr
ericonr reviewed Jun 30, 2022
View reviewed changes
srcpkgs/inkscape/template Outdated
Comment on lines 5 to 7
wrksrc="inkscape-${version}_2021-09-20_3bf5ae0d25"
version=1.2
revision=1
_pkgdate="2022-05-15"
_pkgcommit="dc2aedaf03"
wrksrc="inkscape-${version}_${_pkgdate}_${_pkgcommit}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any reason to make variables for these two values? They aren't used elsewhere...

Otherwise I think it's good to merge. Sorry for the delay.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was inspired by alpine linux. any suggestion?

https://git.alpinelinux.org/aports/tree/community/inkscape/APKBUILD

@hervyqa hervyqa force-pushed the inkscape branch 2 times, most recently from 12006f6 to bd42bdd Compare June 30, 2022 20:27
@hervyqa hervyqa changed the title inkscape: update to 1.2 inkscape: update to 1.2.1 Jul 15, 2022
@hervyqa
Copy link
Contributor Author

hervyqa commented Jul 15, 2022

inkscape 1.2.1 still fail in lpe test. cc @ericonr

The following tests FAILED:
	 30 - test_lpe (Failed)

@paper42
Copy link
Member

paper42 commented Jul 16, 2022

@hervyqa I somehow got to the Author field of the commit, but you did all of the work. Could you change it to your name?

@hervyqa
Copy link
Contributor Author

hervyqa commented Jul 16, 2022

@hervyqa I somehow got to the Author field of the commit, but you did all of the work. Could you change it to your name?

Oh sorry.. done.

@dmarto
Copy link
Contributor

dmarto commented Sep 25, 2022

Can not help with the test failing in CI, but wanted to mention that I have been using Inkscape build from this PR, for some days now and everything (or at least the stuff I use) works perfect, that is on x86_64-glibc; and if there is something that I can help with - ping me.

@hervyqa
Copy link
Contributor Author

hervyqa commented Sep 25, 2022

I hope in version 1.3 later all tests are successful. hope so

@hervyqa hervyqa changed the title inkscape: update to 1.2.1 inkscape: update to 1.2.2 Dec 7, 2022
@manfredu
Copy link
Contributor

manfredu commented Jan 8, 2023 •
edited

I try to build inkscape with this template but without success:

=> inkscape-1.2.2_1: installing host dependencies: automake-1.16.5_1 pkg-config-0.29.2_3 libtool-2.4.7_3 intltool-0.51.0_6 gettext-0.21_4 glib-devel-2.74.0_3 perl-XML-Parser-2.46_4 which-2.21_3 cmake-3.25.1_1 ninja-1.11.1_2 ...
=> inkscape-1.2.2_1: installing target dependencies: harfbuzz-devel-5.1.0_2 libsoup-devel-2.74.0_1 gsl-devel-2.7.1_1 pango-devel-1.50.12_1 libatomic_ops-devel-7.6.14_1 double-conversion-devel-3.1.5_1 gc-devel-8.2.2_1 libwpd-devel-0.10.3_1 libcdr-devel-0.1.7_4 libvisio-devel-0.1.7_5 poppler-devel-22.12.0_1 libwpd-devel-0.10.3_1 potrace-devel-1.16_2 gtkmm-devel-3.24.5_1 gdl-devel-3.40.0_1 gtkspell3-devel-3.0.10_3 aspell-devel-0.60.8_5 libxslt-devel-1.1.37_2 libgomp-devel-12.2.0_1 libwpg-devel-0.3.3_1 poppler-glib-devel-22.12.0_1 ...
=> inkscape-1.2.2_1: removing autodeps, please wait...
=> ERROR: inkscape-1.2.2_1: failed to install target dependencies! (error 19)
ncurses-libs-6.2_4 in transaction breaks installed pkg `ncurses-6.3_1'                                                  
Transaction aborted due to unresolved dependencies.
=> ERROR: Please see above for the real error, exiting...

What could be causing this...?

@paper42
Copy link
Member

paper42 commented Jan 8, 2023

What could be causing this...?

Something on your side, try rebasing this branch on top of master and deleting hostdir/binpkgs, it could have an old build of ncurses.

@manfredu
Copy link
Contributor

manfredu commented Jan 8, 2023

What could be causing this...?

Something on your side, try rebasing this branch on top of master and deleting hostdir/binpkgs, it could have an old build of ncurses.

Deleting hostdir/binpkgs did help, thanks!

@hervyqa hervyqa force-pushed the inkscape branch 2 times, most recently from 7858672 to 6e88367 Compare February 14, 2023 15:49
@biopsin biopsin mentioned this pull request Mar 13, 2023
Closed
@1is7ac3
Copy link
Contributor

1is7ac3 commented Apr 8, 2023

hello. as it goes, in inkscape almost 100% functional.
checking necessary dependencies on:
https://gitlab.com/inkscape/inkscape-ci-docker/-/raw/master/install_dependencies.sh
I have added the necessary dependencies to build, and that the spell checker and extensions work
I built this PR locally for my native architecture, (x86_64, i686)

hostmakedepends="automake pkg-config libtool intltool gettext
glib-devel perl-XML-Parser which libmagick-devel"
makedepends="harfbuzz-devel libsoup-devel gsl-devel pango-devel libatomic_ops-devel
double-conversion-devel gc-devel libwpd-devel libcdr-devel libvisio-devel
poppler-devel libwpd-devel potrace-devel gtkmm-devel gdl-devel gspell-devel
aspell-devel libxslt-devel libgomp-devel libwpg-devel poppler-glib-devel
cairomm-devel hunspell-devel gtkspell3-devel"
depends="desktop-file-utils hicolor-icon-theme python3-appdirs python3-lxml python3-numpy
python3-scour python3-Pillow python3-cssselect python3-requests"

@hervyqa hervyqa force-pushed the inkscape branch 2 times, most recently from b9d5cbb to 7a83d3a Compare April 28, 2023 15:43
sirkhancision pushed a commit to sirkhancision/void-packages that referenced this pull request Jun 27, 2023
@hervyqa @sirkhancision
inkscape: update to 1.2.2
17f79ed 
closes void-linux#35454
rederick29 pushed a commit to rederick29/void-packages that referenced this pull request Jun 29, 2023
@hervyqa @rederick29
inkscape: update to 1.2.2
175d55c 
closes void-linux#35454
hholst80 pushed a commit to hholst80/void-packages that referenced this pull request Jul 5, 2023
@hervyqa @hholst80
inkscape: update to 1.2.2
2c0d346 
closes void-linux#35454
@hervyqa hervyqa deleted the inkscape branch July 26, 2023 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericonr ericonr ericonr left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@hervyqa @tibequadorian @ericonr @hsnfirdaus @oreo639 @paper42 @dmarto @manfredu @1is7ac3