Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sfeed: update to 1.2. #35542

Merged
merged 1 commit into from
Feb 14, 2022
Merged

sfeed: update to 1.2. #35542

merged 1 commit into from
Feb 14, 2022

Conversation

notthewave
Copy link
Contributor

Testing the changes

  • I tested the changes in this PR: YES

@notthewave
Copy link
Contributor Author

notthewave commented Feb 11, 2022

@Chocimier is that the way to do it? Also should I include anything else the maintainer of sfeed proposed in #35521?

@Chocimier
Copy link
Member

Correct.
Conflicts an provides are better solved by transitional package. Not sure what make_use_env is for. vdoc readme look useful unless it repeats manpages.

@notthewave
Copy link
Contributor Author

notthewave commented Feb 11, 2022

looks useful. tons of examples - does not seen to repeat man pages

considering ncurses is in base-system should it even be in depends= ?

@notthewave
Copy link
Contributor Author

notthewave commented Feb 13, 2022

First I decied to remove it since some packages don't install base-sytem dependencies, but then I saw multiple listing it in depends= (including the original sfeed_curses). So I reverted the change again. sorry for cloging up your inbox.

You can merge this. But maybe clarify if packages in base-system should be added to depends= or not (Manual.md).

@tibequadorian
Copy link
Contributor

ncurses in depends= is not required because xbps already detects ncurses-libs as a required dependency.
Not because it's in base-system as users might also want to use base-minimal instead.

@notthewave
Copy link
Contributor Author

Ok thanks for clarification.

@paper42 paper42 merged commit 3a0f6f1 into void-linux:master Feb 14, 2022
@dkwo
Copy link
Contributor

dkwo commented Feb 16, 2022

Why was lynx removed from depends?

@notthewave
Copy link
Contributor Author

sfeed_content formats feed data (TSV) from sfeed(1) from stdin or for
     each file to stdout as plain-text content.  For HTML content it uses
     lynx(1) to convert it to plain-text.  At the end it uses the pager to
     view the output.  The sfeed_content script can be used by sfeed_curses(1)
     to view content.

SFEED_HTMLCONV
             The program used to convert HTML content to plain-text.  If it is
             not set it will use lynx by default.

It can be set by the user, however lynx is the default.

Not sure what to prefer here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants