Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new package: ghcup-0.1.17.8 #35624

Closed
wants to merge 1 commit into from
Closed

Conversation

kwshi
Copy link
Contributor

@kwshi kwshi commented Feb 15, 2022

Testing the changes

  • I tested the changes in this PR: YES

New package

  • This new package conforms to the quality requirements:

    YES:

    1. System-wide: ghcup is meant to be installed system-wide, even though it
      manages per-user installations of the Haskell toolchain (essentially
      analogous to rustup for Rust or opam for OCaml)

    2. Compiled: Yep

    3. Required (by other packages): no, but it's a very useful tool for Haskell
      developers, in the same way that rustup is useful for Rust devs,
      npm/pnpm/yarn is for JS devs, etc.

Local build testing

  • I built this PR locally for my native architecture, (x86_64-glibc)
  • I couldn't test build this PR locally for other architectures because,
    apparently, we can't cross-compile with Haskell yet.

@paper42 paper42 added the new-package This PR adds a new package label Feb 18, 2022
@prez
Copy link
Contributor

prez commented Mar 13, 2022

Is there anything that keeps this from getting merged? Thanks.

@kwshi
Copy link
Contributor Author

kwshi commented Jun 4, 2022

As of recently, the build has starting breaking for me, presumably because Void has updated its GHC to 9.0.2 (9836c28), introducing some version-solving errors with ghcup's dependencies (which explicitly depend on a version of base older than the one included in GHC 9.0.2). I'm working on getting it fixed right now...

srcpkgs/ghcup/template Outdated Show resolved Hide resolved
srcpkgs/ghcup/template Outdated Show resolved Hide resolved
@hasufell
Copy link

hasufell commented Jun 4, 2022

You should print a post-install message like arch: https://aur.archlinux.org/cgit/aur.git/tree/ghcup-hs-bin.install?h=ghcup-hs-bin

srcpkgs/ghcup/template Outdated Show resolved Hide resolved
@hasufell
Copy link

hasufell commented Jun 4, 2022

Here's a patch to fix building with GHC-9.0.2: https://gist.github.com/hasufell/164af24885c6f066291c417a9850388d

@kwshi kwshi force-pushed the ghcup-0.1.17.4 branch 4 times, most recently from c4966a5 to 7eb0685 Compare June 5, 2022 02:12
@kwshi kwshi changed the title new package: ghcup-0.1.17.4 new package: ghcup-0.1.17.8 Jun 5, 2022
@kwshi kwshi force-pushed the ghcup-0.1.17.4 branch 3 times, most recently from f5ed6cb to 09303c6 Compare June 5, 2022 18:35
@kwshi
Copy link
Contributor Author

kwshi commented Jun 10, 2022

I've applied @hasufell's patch and gotten the build to work; compilation on/to non-x86_64 architectures or musl unfortunately doesn't work currently because some of ghcup's dependencies are incompatible (e.g., haskell's libarchive package explicitly imports a glibc header). This package template is ready for review.

@hasufell
Copy link

I've applied @hasufell's patch and gotten the build to work; compilation on/to non-x86_64 architectures or musl unfortunately doesn't work currently because some of ghcup's dependencies are incompatible (e.g., haskell's libarchive package explicitly imports a glibc header). This package template is ready for review.

That can't be. The ghcup binaries are built on alpine linux with musl.

There's a static libarchive option: -f-system-libarchive

@kwshi
Copy link
Contributor Author

kwshi commented Jun 10, 2022

I've applied @hasufell's patch and gotten the build to work; compilation on/to non-x86_64 architectures or musl unfortunately doesn't work currently because some of ghcup's dependencies are incompatible (e.g., haskell's libarchive package explicitly imports a glibc header). This package template is ready for review.

That can't be. The ghcup binaries are built on alpine linux with musl.

There's a static libarchive option: -f-system-libarchive

Weird-- I've tried building with -f-system-libarchive and the error still appears. The relevant error message, I think, is

c/archive_platform.h:84:10: error:
     fatal error: sys/cdefs.h: No such file or directory
       84 | #include <sys/cdefs.h>
          |          ^~~~~~~~~~~~~
   |
84 | #include <sys/cdefs.h>

Where all googled instances of sys/cdefs.h seem to point to GNU libc. The full error log on the workflow run is at https://github.com/void-linux/void-packages.

I've updated the package template to use -f-system-libarchive, and as you can see from the CI logs the same error still occurs; cabal is still trying to build the libarchive library, even though per my understanding it shouldn't (if we're using static libarchive).

I'll do some more investigation on alpine to see what might explain this disparity.

@kwshi kwshi marked this pull request as draft June 10, 2022 14:51
@github-actions
Copy link

github-actions bot commented Sep 9, 2022

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label Sep 9, 2022
@kwshi
Copy link
Contributor Author

kwshi commented Sep 9, 2022

bumping; still working on this!

@github-actions github-actions bot removed the Stale label Sep 10, 2022
@github-actions
Copy link

github-actions bot commented Dec 9, 2022

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label Dec 9, 2022
@github-actions github-actions bot closed this Dec 24, 2022
@slotThe slotThe mentioned this pull request Dec 27, 2022
28 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-package This PR adds a new package Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants