Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: q5go-2.13 #35831

Merged
merged 1 commit into from May 18, 2022
Merged

New package: q5go-2.13 #35831

merged 1 commit into from May 18, 2022

Conversation

jason1987d
Copy link
Contributor

  • I tested the changes in this PR: YES

New package

  • This new package conforms to the quality requirements: YES

  • I built this PR locally for my native architecture, (x86_64-libc)

  • I built this PR locally for these architectures (if supported. mark crossbuilds):

    • aarch64-musl
    • armv7l
    • armv6l-musl

@tibequadorian
Copy link
Contributor

Please don't create new PRs over and over, it's better to git commit --amend and force push your changes: https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#review

@jason1987d
Copy link
Contributor Author

Noted, and my apologies. I have set my default git pull strategy to be rebase to avoid any other issues with merge commits and amendments. Is anything else required for explanation of this package or pull request?

The older package (~2008) qGo is in void's repos, but this program is a massive upgrade of that using qt5.

@paper42 paper42 added the new-package This PR adds a new package label Feb 26, 2022
Comment on lines 8 to 9
hostmakedepends="qt5-qmake qt5-multimedia-devel qt5-svg-devel qt5-host-tools"
makedepends="qt5-qmake qt5-multimedia-devel qt5-svg-devel"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
hostmakedepends="qt5-qmake qt5-multimedia-devel qt5-svg-devel qt5-host-tools"
makedepends="qt5-qmake qt5-multimedia-devel qt5-svg-devel"
hostmakedepends="qt5-qmake qt5-host-tools"
makedepends="qt5-multimedia-devel qt5-svg-devel"

Comment on lines 18 to 19
qmake -install qinstall "${wrksrc}/src/images/clientwindow/Bowl.png" "${DESTDIR}/usr/share/q5go/Bowl.png"
qmake -install qinstall "${wrksrc}/templates/qgo.desktop" "${DESTDIR}/usr/share/applications/q5go.desktop"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I there an advantage of this overvinstall?

post_install() {
qmake -install qinstall "${wrksrc}/src/images/clientwindow/Bowl.png" "${DESTDIR}/usr/share/q5go/Bowl.png"
qmake -install qinstall "${wrksrc}/templates/qgo.desktop" "${DESTDIR}/usr/share/applications/q5go.desktop"
sed -i -e 's/Name=qgo/Name=q5go/g' -e 's/Comment=qgo/Comment=q5go/g' -e 's/Exec=qgo/Exec=q5go/g' -e 's/Icon=\/usr\/share\/qGo\/pics\/Bowl\.png/Icon=\/usr\/share\/q5go\/Bowl\.png/g' -e 's/MimeType=text\/plain\;text\/sfg\;Application/MimeType=application\/x-go-sgf;/g' "${DESTDIR}/usr/share/applications/q5go.desktop"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please replace with a patch and send it upstream.

@jason1987d jason1987d closed this May 16, 2022
@jason1987d jason1987d reopened this May 16, 2022
@jason1987d
Copy link
Contributor Author

My branch got messed up, and accidentally closed the PR when cleaning that up. Was able to recover the template.
However, a new version 2.13 of this has released, and I will also address the icon/desktop files as patches and not how I did.

@jason1987d jason1987d changed the title New package: q5go-2.12 New package: q5go-2.13 May 16, 2022
@jason1987d
Copy link
Contributor Author

jason1987d commented May 17, 2022

I have this all fixed now, with patches to q(5)go.desktop.

@jason1987d
Copy link
Contributor Author

Also, I will be looking to build a template for software that works well with this KataGo https://github.com/lightvector/KataGo/blob/master/Compiling.md but has multiple backends (OpenCL,CUDA,TensorRT,Eigen) to choose from. When organizing a template, would it be done as a subpackage for each possible backend?

@Chocimier Chocimier merged commit e392f1b into void-linux:master May 18, 2022
@Chocimier
Copy link
Member

would it be done as a subpackage for each possible backend

Likely, let's discuss in dedicated PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-package This PR adds a new package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants