New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New package: q5go-2.13 #35831
New package: q5go-2.13 #35831
Conversation
Please don't create new PRs over and over, it's better to |
Noted, and my apologies. I have set my default git pull strategy to be rebase to avoid any other issues with merge commits and amendments. Is anything else required for explanation of this package or pull request? The older package (~2008) qGo is in void's repos, but this program is a massive upgrade of that using qt5. |
srcpkgs/q5go/template
Outdated
hostmakedepends="qt5-qmake qt5-multimedia-devel qt5-svg-devel qt5-host-tools" | ||
makedepends="qt5-qmake qt5-multimedia-devel qt5-svg-devel" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hostmakedepends="qt5-qmake qt5-multimedia-devel qt5-svg-devel qt5-host-tools" | |
makedepends="qt5-qmake qt5-multimedia-devel qt5-svg-devel" | |
hostmakedepends="qt5-qmake qt5-host-tools" | |
makedepends="qt5-multimedia-devel qt5-svg-devel" |
srcpkgs/q5go/template
Outdated
qmake -install qinstall "${wrksrc}/src/images/clientwindow/Bowl.png" "${DESTDIR}/usr/share/q5go/Bowl.png" | ||
qmake -install qinstall "${wrksrc}/templates/qgo.desktop" "${DESTDIR}/usr/share/applications/q5go.desktop" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I there an advantage of this overvinstall
?
srcpkgs/q5go/template
Outdated
post_install() { | ||
qmake -install qinstall "${wrksrc}/src/images/clientwindow/Bowl.png" "${DESTDIR}/usr/share/q5go/Bowl.png" | ||
qmake -install qinstall "${wrksrc}/templates/qgo.desktop" "${DESTDIR}/usr/share/applications/q5go.desktop" | ||
sed -i -e 's/Name=qgo/Name=q5go/g' -e 's/Comment=qgo/Comment=q5go/g' -e 's/Exec=qgo/Exec=q5go/g' -e 's/Icon=\/usr\/share\/qGo\/pics\/Bowl\.png/Icon=\/usr\/share\/q5go\/Bowl\.png/g' -e 's/MimeType=text\/plain\;text\/sfg\;Application/MimeType=application\/x-go-sgf;/g' "${DESTDIR}/usr/share/applications/q5go.desktop" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please replace with a patch and send it upstream.
My branch got messed up, and accidentally closed the PR when cleaning that up. Was able to recover the template. |
I have this all fixed now, with patches to q(5)go.desktop. |
Also, I will be looking to build a template for software that works well with this KataGo https://github.com/lightvector/KataGo/blob/master/Compiling.md but has multiple backends (OpenCL,CUDA,TensorRT,Eigen) to choose from. When organizing a template, would it be done as a subpackage for each possible backend? |
Likely, let's discuss in dedicated PR. |
New package
This new package conforms to the quality requirements: YES
I built this PR locally for my native architecture, (x86_64-libc)
I built this PR locally for these architectures (if supported. mark crossbuilds):