Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

google-chrome: add missing gtk+3 dependency #35916

Merged
merged 1 commit into from
Mar 3, 2022
Merged

google-chrome: add missing gtk+3 dependency #35916

merged 1 commit into from
Mar 3, 2022

Conversation

yiz
Copy link
Contributor

@yiz yiz commented Mar 2, 2022

Google Chrome would crash without gtk+3.

Testing the changes

  • I tested the changes in this PR: YES
  • I built this PR locally for my native architecture, x86_64

@paper42
Copy link
Member

paper42 commented Mar 2, 2022 •
edited
Loading

Please increase the revision.
@atk

@paper42 paper42 mentioned this pull request Mar 2, 2022
Closed
@paper42
Copy link
Member

paper42 commented Mar 2, 2022

also please:

  • use imperative in the commit message: google-chrome: add missing gtk+3 dependency
  • make sure the commit email is associated with your github profile, currently it isn't, so the commit isn't properly attributed to you in the GitHub UI.

@yiz yiz changed the title google-chrome: adds missing gtk+3 dependency google-chrome: add missing gtk+3 dependency Mar 3, 2022
@yiz
Copy link
Contributor Author

yiz commented Mar 3, 2022

Thanks @paper42 . All updated.

@paper42 paper42 merged commit 69c051e into void-linux:master Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yiz @paper42