OpenLP: update to 2.9.4. #36014
Merged
OpenLP: update to 2.9.4. #36014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I pulled a patch that was added to the project after this tag to fix one of the errors, but the other one is still broken on the latest commit, so I just deselected it for now. |
|
Thanks, I do not use it daily, so didn't noticed it was broken by some pyqt(?) update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing the changes
Current version in repo is broken due to what I'm suspecting are just deprecation errors, and is also very old (March 31, 2017). This version is technically an RC for 3.0 but since it works and the current version in repo doesn't, I figured I would open a PR.