New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
podman: add runit service #36102
podman: add runit service #36102
Conversation
Oh, I thought the main point of the service is to replace docker. I never thought about starting the service for anything else. What would one use it for, if not for a docker replacement? |
Hmm. Perhaps defaulting to the docker socket makes sense then. But having it configurable is good in my opinion. E.g. for those that want remote access. Also the log level could be configurable too. So my recommendation is |
I can live with that. I'd still love to hear from @leahneukirchen, what they think about it. |
Imo the service should be used with |
Hmm, perhaps we should have two services, because my intent was to use this to replace docker completely. |
@the-maldridge yeah, I was thinking the same. |
Note that podman starts the socket with hard-coded 0700 permissions, so it's only usable by root by default anyway. If you want to "replace docker completely", I don't see the problem here as just using podman instead of docker (or even aliasing it) will work. From personal experience, I'd recommend not using the docker client to speak to a podman server if you can avoid it. |
As promised, I added the |
@leahneukirchen @CameronNemo I am happy with the changes in this PR, do you have any concerns before I merge this? |
LGTM |
I don't think the fake service for the symlink is necessary or required, why not just add that to the normal service? |
@Duncaen that was my first suggestion, but we decided against it. |
Upstream Systemd service doesn't do anything special.
--time=0 unix:///var/run/docker.sock
is required, since we don't have socket activation.