fish-shell: update to 3.4.1.

[triallax]

Testing the changes

• I tested the changes in this PR: YES

If you use an older Fish version as your shell and update to 3.4.0, you'll get the following (I believe harmless) error after the upgrade command finishes running and in some other instances:

/usr/share/fish/functions/fish_title.fish (line 7): $(...) is not supported. In fish, please use '(prompt_hostname)'.
        and set ssh "[$(prompt_hostname | string sub -l 10)]"
                      ^
from sourcing file /usr/share/fish/functions/fish_title.fish
in command substitution
source: Error while reading file “/usr/share/fish/functions/fish_title.fish”

To be clear this does not happen when running the updated Fish 3.4.0)

Am I supposed to handle that somehow? Fixed in 3.4.1.

Local build testing

• I built this PR locally for my native architecture, x86_64-glibc

[zen0bit]

Looks like I found solution

Maybe add patch for it?
Never do that ...

change
"[$(prompt_hostname | string sub -l 10)]"
to
"["(prompt_hostname | string sub -l 10 | string collect)"]"

no error for me after change...

[triallax]

The error only occurs because Fish 3.4.0 introduces a new syntax that the script in question was modified to use in Fish 3.4.0, and older Fish versions don't recognize that syntax. Thus, any Fish sessions started after the update will not be affected. I think applying such a patch is not a good idea, but I'll leave that choice to the maintainers.

[Vistaus]

I also don't think applying such a patch is a good idea. Just restart your fish shell.

[paper42]

Is this something that will happen only in specific circumstances or for all users? If this would happen to all users, we could add an install message.

[triallax]

@paper42 well, not strictly all users it seems. From https://fishshell.com/docs/current/cmds/fish_title.html:

This requires that your terminal supports programmable titles and the feature is turned on.

I'm not sure about this, but it probably also wouldn't affect those who have a custom fish_title function (as shown in the example in the URL above). However, it's not like we know how many Fish users aren't affected, so it may be safe to assume that the majority will face that error.

[paper42]

However, it's not like we know how many Fish users aren't affected, so it may be safe to assume that the majority will face that error.

In that case let's add an install message, we can remove it with the next update.

[Chocimier]

Upsteam patched out new syntax, i would prefer to import that.
fish-shell/fish-shell@c5a8764

[triallax]

@Chocimier guess I'll do that.

[triallax]

I updated the PR to Fish 3.4.1, which fixes that issue (see https://github.com/fish-shell/fish-shell/releases/tag/3.4.1).