Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: airshipper-0.7.0. #36140

Closed
wants to merge 1 commit into from
Closed

Conversation

teldra
Copy link
Contributor

@teldra teldra commented Mar 14, 2022

solves #36127

Testing the changes

  • I tested the changes in this PR: YES

New package

Local build testing

  • I built this PR locally for my native architecture, (x86_64-glibc)
  • I built this PR locally for these architectures (if supported. mark crossbuilds):
    • aarch64-musl

@teldra teldra changed the title New package: airshipper-0.7.0. [WIP] New package: airshipper-0.7.0. Mar 14, 2022
@tibequadorian
Copy link
Contributor

Is it possible to move do_install() to post_install() and remove the vbin line?

@teldra
Copy link
Contributor Author

teldra commented Mar 15, 2022

Is it possible to move do_install() to post_install() and remove the vbin line?

Sadly it seems, it is not possible. The error when changed: error: found a virtual manifest at /builddir/airshipper-v0.7.0/Cargo.toml instead of a package manifest

Or am I missing something?

@teldra teldra changed the title [WIP] New package: airshipper-0.7.0. New package: airshipper-0.7.0. Mar 15, 2022
@teldra
Copy link
Contributor Author

teldra commented Mar 15, 2022

I add this launcher, because Veloren needs rust with nightly featureset we not provide. And Veloren is updated quite frequently.

@tibequadorian
Copy link
Contributor

Alright, I don't think you're missing something. Thanks for testing :)

@tibequadorian
Copy link
Contributor

tibequadorian commented Mar 17, 2022

airshipper works fine for me.

I'm not sure about airshipper-server though. It should not be confused with the Veloren server.
This is only the server to communicate with airshipper clients, which is probably only used by the developers.
I think we shouldn't ship it to avoid confusion.

@paper42 paper42 added the new-package This PR adds a new package label Mar 20, 2022
@tibequadorian
Copy link
Contributor

Can you say how you tested airshipper-server, @teldra?

@teldra
Copy link
Contributor Author

teldra commented Mar 31, 2022

Can you say how you tested airshipper-server, @teldra?

Sry for late answer.
I just tested, if the binary is running. It stops, when it don't find any configfile. I did not want to hide the server component in the main template. But when I think about, it is not needed, right?

@tibequadorian
Copy link
Contributor

If we can't test it properly and it's of no use for us, there's no point in shipping it.
It also looks like the server urls are hardcoded in the client.

@tibequadorian
Copy link
Contributor

Is it possible to move do_install() to post_install() and remove the vbin line?

If you set build_wrksrc=client this^ should be possible and avoids building the server for nothing.

@teldra teldra force-pushed the new-airshipper branch 3 times, most recently from 250dce9 to 30e650c Compare March 31, 2022 22:44
@teldra
Copy link
Contributor Author

teldra commented Mar 31, 2022

I think, this template is mergeable, now. :)

@teldra teldra force-pushed the new-airshipper branch 2 times, most recently from 46b7e12 to 1b268a7 Compare March 31, 2022 23:26
Copy link
Contributor

@tibequadorian tibequadorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thank you :)

@teldra teldra force-pushed the new-airshipper branch 3 times, most recently from 761597c to 59467ef Compare May 18, 2022 11:09
@tibequadorian
Copy link
Contributor

bump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-package This PR adds a new package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants