Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

glm: fix license, copy cmake config files #36213

Closed
wants to merge 1 commit into from
Closed

glm: fix license, copy cmake config files #36213

wants to merge 1 commit into from

Conversation

Radfordhound
Copy link
Contributor

Testing the changes

  • I tested the changes in this PR: YES

Local build testing

  • I built this PR locally for my native architecture, (x86_64-glibc)

tibequadorian
tibequadorian reviewed Mar 18, 2022
View reviewed changes
srcpkgs/glm/template Outdated Show resolved Hide resolved
@Radfordhound
Copy link
Contributor Author

I've force pushed to remove the lengthy descriptions from my commit messages so the lint template check succeeds.

tibequadorian
tibequadorian reviewed Mar 19, 2022
View reviewed changes
srcpkgs/glm/template Outdated Show resolved Hide resolved
@tibequadorian
Copy link
Contributor

Don't seperate your changes into multiple commits. Just do one commit with a description. You also need to revbump.

@Radfordhound
Copy link
Contributor Author

Gotcha. I've merged all the commits into one and bumped the revision number to 2.

tibequadorian
tibequadorian approved these changes Mar 19, 2022
View reviewed changes
Copy link
Contributor

@tibequadorian tibequadorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@github-actions
Copy link

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label Jun 29, 2022
@Radfordhound
Copy link
Contributor Author

Bumping this as I believe it to still be relevant.

@github-actions github-actions bot removed the Stale label Jun 30, 2022
@github-actions
Copy link

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label Sep 29, 2022
@Radfordhound
Copy link
Contributor Author

Not trying to nag lol, but bumping this again as I still believe it to be relevant

@github-actions github-actions bot removed the Stale label Oct 5, 2022
classabbyamp
classabbyamp reviewed Dec 19, 2022
View reviewed changes
Copy link
Member

@classabbyamp classabbyamp left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you rebase and fix conflicts? (remove the wrksrc line)

srcpkgs/glm/template Outdated Show resolved Hide resolved
@Radfordhound
Copy link
Contributor Author

Sure thing. Conflicts should be resolved now, and I've removed the -f from the remove command as suggested.

BlindRepublic pushed a commit to BlindRepublic/void-packages that referenced this pull request Feb 11, 2023
@Radfordhound @BlindRepublic
glm: fix license, copy cmake config files
4db58d2 
closes void-linux#36213
Luc-Saccoccio pushed a commit to Luc-Saccoccio/void-packages that referenced this pull request Mar 26, 2023
@Radfordhound @Luc-Saccoccio
glm: fix license, copy cmake config files
88aa71a 
closes void-linux#36213
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@classabbyamp classabbyamp classabbyamp left review comments

@tibequadorian tibequadorian tibequadorian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Radfordhound @tibequadorian @classabbyamp