Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] ocaml: fix build on aarch64-musl #36268

Closed
wants to merge 6 commits into from

Conversation

ftrvxmtrx
Copy link
Contributor

Earlier fix for *-musl platforms has been "nopie=yes", which disables
PIE by modifying CFLAGS/LDFLAGS/... during build. This results in
OCaml's runtime shared library linking fail.

Later OCaml releases incorporated a fix for *-musl platforms that
properly disables PIE only where required.

Set nopie_files instead, which respects OCaml's build system choice
of CFLAGS/LDFLAGS/... and fixes aarch64-build.

I am not entirely sure whether nopie=yes in every package is a good idea. It seems to only be required on *-musl except x86_64-musl(?).

Testing the changes

  • I tested the changes in this PR: YES

Local build testing

  • I built this PR locally for my native architecture, (aarch64-musl)

[ci skip]

Earlier fix for *-musl platforms has been "nopie=yes", which disables
PIE by modifying CFLAGS/LDFLAGS/... during build. This results in
OCaml's runtime shared library linking fail.

Later OCaml releases incorporated a fix for *-musl platforms that
properly disables PIE only where required.

Set nopie_files instead, which respects OCaml's build system choice
of CFLAGS/LDFLAGS/... and fixes aarch64-build.
@github-actions
Copy link

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label Jun 29, 2022
@leahneukirchen
Copy link
Member

OCaml 4.14 seems to generate PIE executables on aarch64-musl.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants