Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i2c-tools: change upstream and add python subpkg #36304

Merged
merged 1 commit into from Jun 13, 2022

Conversation

0x5c
Copy link
Contributor

@0x5c 0x5c commented Mar 23, 2022

Things I am still unsure about:

  • The subpackage name and short_desc
  • How to ensure the subpackage's version is the version of the python module (it is versioned separately)

Closes #36156

Testing the changes

  • I tested the changes in this PR: briefly
    • Distfile location change had no impact (same exact file as debian's)
    • Package builds fine and with the right files in the right place
    • Crossbuilds fine
    • Tested the python bindings

@leahneukirchen

@leahneukirchen
Copy link
Member

You can't have a different version for a subpkg. Either make a new package, or just put it into the main package. Or use the "wrong" version.

@0x5c
Copy link
Contributor Author

0x5c commented Mar 29, 2022

I decided that the version would simply be i2c-tools' version; since the version is only exposed in the module metadata inside i2c-tools' distfile, and since the distfile is versioned with i2c-tools' version, it would be an absolute mess to deal as a separate package.

I still have to fix crossbuilds and the python module building in the install phase, but I have a lead on that, just no testing time right now.

@0x5c
Copy link
Contributor Author

0x5c commented May 7, 2022

The python module build happening in do_install has been fixed, but cross builds still have the problem where Python.h cannot be found.
However, the build succeeds if python3-devel is moved to hostmakedends, which doesn't seem right to me.

@0x5c
Copy link
Contributor Author

0x5c commented May 23, 2022

All problems fixed, remains to test if it actually runs properly

@0x5c 0x5c force-pushed the i2c-python branch 3 times, most recently from 27d1d74 to 6f752cc Compare May 27, 2022 23:22
@0x5c
Copy link
Contributor Author

0x5c commented Jun 12, 2022

I was finally able to test this on a rpi1b

This is now ready for review

@0x5c 0x5c marked this pull request as ready for review June 12, 2022 01:19
@leahneukirchen leahneukirchen merged commit b05d95f into void-linux:master Jun 13, 2022
@0x5c 0x5c deleted the i2c-python branch June 13, 2022 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

package request python3-smbus
3 participants