Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lensfun: update to 0.3.3. #36343

Closed
wants to merge 1 commit into from

Conversation

Vagabond
Copy link

Testing the changes

  • I tested the changes in this PR: YES I tested by installing the new lensfun and checking the new lenses were available in darktable.

Local build testing

  • I built this PR locally for my native architecture, (amd64)

@@ -1686,7 +1686,7 @@ libIlmImfUtil-2_4.so.24 libopenexr-2.4.0_1
libGraphicsMagick.so.3 libgraphicsmagick-1.3.19_1
libGraphicsMagick++.so.12 libgraphicsmagick-1.3.22_1
libGraphicsMagickWand.so.2 libgraphicsmagick-1.3.19_1
liblensfun.so.1 lensfun-0.3.2_1
liblensfun.so.1 lensfun-0.3.3_1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't do this if the soname doesn't change

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do you tell if it changed? It seems like it changed?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The soname is in the first column and it didn't change. Second column is the package with the minimal version which provides this soname.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

xbps-src would exit with an error if soname changed and you didn't change it in common/shlibs.

@github-actions
Copy link

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label Jun 30, 2022
@github-actions github-actions bot closed this Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants